Retry 114494 - Remove BindStateHolder and have Bind() return a Callback<> object directly."

Retry 114494 - Remove BindStateHolder and have Bind() return a Callback<> object directly."

This removes some complexity and also fixes a bug where if you call Bind() with the result of Bind(), the resulting Callback would only be valid during the first call. Ouch.

Also makes the static type checking a bit more strict when assigning into a Callback<>.

BUG=none
TEST=new unittests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115045

[awong, 2011-12-19 22:04:50]

stevenjb: Just the chrome/browser/chromeos parts please.

willchan: it's a reapply of the old patch, so just hoping for OWNERS rubber
stamp.

[willchan no longer on Chromium, 2011-12-19 22:21:10]

Lgtm
On Dec 19, 2011 2:04 PM, <ajwong@chromium.org> wrote:

> Reviewers: stevenjb, willchan,
>
> Message:
> stevenjb: Just the chrome/browser/chromeos parts please.
>
> willchan: it's a reapply of the old patch, so just hoping for OWNERS rubber
> stamp.
>
> Description:
> Retry 114494 - Remove BindStateHolder and have Bind() return a Callback<>
> object
> directly."
>
> This removes some complexity and also fixes a bug where if you call Bind()
> with
> the result of Bind(), the resulting Callback would only be valid during the
> first call. Ouch.
>
> Also makes the static type checking a bit more strict when assigning into a
> Callback<>.
>
> BUG=none
> TEST=new unittests
>
>
> Please review this at
http://codereview.chromium.**org/8915024/<http://codereview.chromium.org/8915...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M base/bind.h
>  M base/bind.h.pump
>  M base/bind_unittest.cc
>  M base/callback.h
>  M base/callback.h.pump
>  M base/callback_internal.h
>  M base/callback_internal.cc
>  M base/callback_unittest.cc
>  M base/cancelable_callback.h
>  M base/debug/trace_event.h
>  M base/debug/trace_event.cc
>  M base/debug/trace_event_**unittest.cc
>  M base/test/trace_event_**analyzer_unittest.cc
>  M chrome/browser/chromeos/dbus/**bluetooth_manager_client.h
>  M chrome/browser/chromeos/disks/**disk_mount_manager.cc
>  M chrome/browser/chromeos/**process_proxy/process_output_**watcher.h
>  M chrome/browser/chromeos/**process_proxy/process_proxy.cc
>  M chrome/browser/chromeos/**process_proxy/process_proxy_**registry.h
>  M chrome/browser/sync/glue/**session_model_associator.h
>  M chrome/browser/sync/glue/**session_model_associator.cc
>  M chrome/browser/sync/internal_**api/sync_manager.cc
>  M media/base/demuxer_stream.h
>  M net/base/cookie_monster_**unittest.cc
>  M net/base/cookie_store_test_**helpers.h
>  M net/base/cookie_store_test_**helpers.cc
>  M net/http/http_proxy_client_**socket.cc
>  M net/socket/socket_test_util.cc
>  M net/socket/web_socket_server_**socket.cc
>  M net/spdy/spdy_proxy_client_**socket_unittest.cc
>
>
>

[stevenjb, 2011-12-19 23:19:53]

Chromeos chages lgtm

[commit-bot: I haz the power, 2011-12-19 23:57:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ajwong@chromium.org/8915024/5002

[commit-bot: I haz the power, 2011-12-19 23:57:21]

Presubmit check for 8915024-5002 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
chrome/browser/sync/glue/session_model_associator.cc,chrome/browser/sync/glue/session_model_associator.h,chrome/browser/sync/internal_api/sync_manager.cc

Presubmit checks took 3.5s to calculate.