net/http/http_proxy_client_socket.cc - Issue 8915024: Retry 114494 - Remove BindStateHolder and have Bind() return a Callback<> object directly."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_proxy_client_socket.cc

Issue 8915024: Retry 114494 - Remove BindStateHolder and have Bind() return a Callback<> object directly." (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_proxy_client_socket.cc

diff --git a/net/http/http_proxy_client_socket.cc b/net/http/http_proxy_client_socket.cc

index 4b03ba8c42c46fa745139d3828cee92ff10effb5..b0ddc32e4b58e5e5b3226842e6388c5f30381d0c 100644

--- a/net/http/http_proxy_client_socket.cc

+++ b/net/http/http_proxy_client_socket.cc

@@ -73,8 +73,7 @@ int HttpProxyClientSocket::RestartWithAuth(OldCompletionCallback* callback) {

rv = DoLoop(OK);

if (rv == ERR_IO_PENDING)

if (callback) {

- user_callback_ = base::Bind(&OldCompletionCallback::Run<int>,

- base::Unretained(callback));

+ user_callback_ = base::Bind(&OldCompletionCallbackAdapter, callback);

}

return rv;

}

« no previous file with comments | « net/base/cookie_store_test_helpers.cc ('k') | net/socket/socket_test_util.cc » ('j') | no next file with comments »