Issue 8915021: Code review changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8915021: Code review changes (Closed)

Created:
9 years ago by sra1

Modified:
9 years ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Code review changes Just layout and comment. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=2447

Patch Set 1 #

Patch Set 2 : comment #

Total comments: 1

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -4 lines)			Patch
	M	frog/member.dart	View	1	1 chunk	+9 lines, -2 lines	0 comments	Download
	M	frog/var_member.dart	View		1 chunk	+4 lines, -2 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

9 years ago (2011-12-14 22:07:07 UTC) #2

http://codereview.chromium.org/8915021/diff/2001/frog/var_member.dart
File frog/var_member.dart (right):

http://codereview.chromium.org/8915021/diff/2001/frog/var_member.dart#newcode249
frog/var_member.dart:249: // to have methods called 'foo' and 'foo$0'.
if the user had a method called foo$0, it would get escaped to foo$$0 and hence
not conflict

Expand Messages | Collapse Messages