Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: frog/member.dart

Issue 8915021: Code review changes (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: comment Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | frog/var_member.dart » ('j') | frog/var_member.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: frog/member.dart
diff --git a/frog/member.dart b/frog/member.dart
index 87da67a77a9664327b3efe140c52fea70efdf242..b3e6adf456649d3596fdd16d2b3cfecb02a5f552 100644
--- a/frog/member.dart
+++ b/frog/member.dart
@@ -817,14 +817,21 @@ class MethodMember extends Member {
return new Value(functionType, '${target.code}.get\$$jsname()', node.span);
}
+ /**
+ * Checks if the named arguments are in their natural or 'home' positions,
+ * i.e. they may be passed directly without inserting, deleting or moving the
+ * arguments to correspond with the parameters.
+ */
bool namesInHomePositions(Arguments args) {
if (!args.hasNames) return true;
for (int i = args.bareCount; i < args.values.length; i++) {
- if (i >= parameters.length)
+ if (i >= parameters.length) {
return false;
- if (args.getName(i) != parameters[i].name)
+ }
+ if (args.getName(i) != parameters[i].name) {
return false;
+ }
}
return true;
}
« no previous file with comments | « no previous file | frog/var_member.dart » ('j') | frog/var_member.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698