Chromium Code Reviews| Index: frog/var_member.dart |
| diff --git a/frog/var_member.dart b/frog/var_member.dart |
| index 7307e95e091f487475e6f9ed68f6856742d62089..f9c67343abe94a451546d4227a1863f5a9bf7582 100644 |
| --- a/frog/var_member.dart |
| +++ b/frog/var_member.dart |
| @@ -245,13 +245,15 @@ class VarMethodSet extends VarMember { |
| String _getCallStubName(String name, Arguments args) { |
| // TODO: This code needs global knowledge to ensure the stub name does not |
| - // collide with any other name. |
| + // collide with any other name. E.g. it is unlikely but possible for the user |
| + // to have methods called 'foo' and 'foo$0'. |
|
Jennifer Messerly
2011/12/14 22:07:08
if the user had a method called foo$0, it would ge
|
| final nameBuilder = new StringBuffer('${name}\$${args.bareCount}'); |
| for (int i = args.bareCount; i < args.length; i++) { |
| var name = args.getName(i); |
| nameBuilder.add('\$'); |
| if (name.contains('\$')) { |
| - // Disambiguate "a:b:" from "a$b:" |
| + // Disambiguate "a:b:" from "a$b:". Using the length works well because |
| + // the names can't start with digits. |
| nameBuilder.add('${name.length}'); |
| } |
| nameBuilder.add(name); |