Issue 8914006: Create missing boilerplate for array literals instead of deoptimizing

Issue 8914006: Create missing boilerplate for array literals instead of deoptimizing (Closed)

Created:
9 years ago by Jakob Kummerow

Modified:
9 years ago

Reviewers:
ricow1, Rico

CC:
v8-dev, fschneider, danno

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Create missing boilerplate for array literals instead of deoptimizing BUG=107370 TEST=new additions to mjsunit/array-literal-transitions Committed: http://code.google.com/p/v8/source/detail?r=10255

Patch Set 2 : address comments #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -14 lines)			Patch
M	src/hydrogen.cc	View	1	1 chunk	+13 lines, -5 lines	0 comments	Download
M	src/hydrogen-instructions.h	View		3 chunks	+7 lines, -4 lines	0 comments	Download
M	src/hydrogen-instructions.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	src/runtime.h	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/runtime.cc	View		4 chunks	+8 lines, -4 lines	0 comments	Download
M	test/mjsunit/array-literal-transitions.js	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

This fixes a bug where OSRing a function before an array literal would result in ...

9 years ago (2011-12-14 12:47:34 UTC) #1

ricow1

LGTM http://codereview.chromium.org/8914006/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): http://codereview.chromium.org/8914006/diff/1/src/hydrogen.cc#newcode3471 src/hydrogen.cc:3471: raw_boilerplate = Runtime::CreateArrayLiteralBoilerplate( Check return value from runtime ...

9 years ago (2011-12-14 12:53:08 UTC) #2

Jakob Kummerow

9 years ago (2011-12-14 13:00:20 UTC) #3

Comments addressed, landing.

http://codereview.chromium.org/8914006/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

http://codereview.chromium.org/8914006/diff/1/src/hydrogen.cc#newcode3471
src/hydrogen.cc:3471: raw_boilerplate = Runtime::CreateArrayLiteralBoilerplate(
On 2011/12/14 12:53:09, ricow1 wrote:
> Check return value from runtime call, could be null

Done.

http://codereview.chromium.org/8914006/diff/1/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/8914006/diff/1/src/runtime.cc#newcode437
src/runtime.cc:437: // static
On 2011/12/14 12:53:09, ricow1 wrote:
> Is this comment intentional?

Yes.

http://codereview.chromium.org/8914006/diff/1/src/runtime.h
File src/runtime.h (right):

http://codereview.chromium.org/8914006/diff/1/src/runtime.h#newcode683
src/runtime.h:683: static Handle<Object> CreateArrayLiteralBoilerplate(
On 2011/12/14 12:53:09, ricow1 wrote:
> This is not really used from a stub, add comment

Done.

Expand Messages | Collapse Messages