Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: src/hydrogen-instructions.cc

Issue 8914006: Create missing boilerplate for array literals instead of deoptimizing (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: address comments Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/hydrogen-instructions.h ('k') | src/runtime.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1209 matching lines...) Expand 10 before | Expand all | Expand 10 after
1220 String::cast(*handle())->length() == 0) return false; 1220 String::cast(*handle())->length() == 0) return false;
1221 return true; 1221 return true;
1222 } 1222 }
1223 1223
1224 void HConstant::PrintDataTo(StringStream* stream) { 1224 void HConstant::PrintDataTo(StringStream* stream) {
1225 handle()->ShortPrint(stream); 1225 handle()->ShortPrint(stream);
1226 } 1226 }
1227 1227
1228 1228
1229 bool HArrayLiteral::IsCopyOnWrite() const { 1229 bool HArrayLiteral::IsCopyOnWrite() const {
1230 return boilerplate_object_->elements()->map() == HEAP->fixed_cow_array_map(); 1230 if (!boilerplate_object_->IsJSObject()) return false;
1231 return Handle<JSObject>::cast(boilerplate_object_)->elements()->map() ==
1232 HEAP->fixed_cow_array_map();
1231 } 1233 }
1232 1234
1233 1235
1234 void HBinaryOperation::PrintDataTo(StringStream* stream) { 1236 void HBinaryOperation::PrintDataTo(StringStream* stream) {
1235 left()->PrintNameTo(stream); 1237 left()->PrintNameTo(stream);
1236 stream->Add(" "); 1238 stream->Add(" ");
1237 right()->PrintNameTo(stream); 1239 right()->PrintNameTo(stream);
1238 if (CheckFlag(kCanOverflow)) stream->Add(" !"); 1240 if (CheckFlag(kCanOverflow)) stream->Add(" !");
1239 if (CheckFlag(kBailoutOnMinusZero)) stream->Add(" -0?"); 1241 if (CheckFlag(kBailoutOnMinusZero)) stream->Add(" -0?");
1240 } 1242 }
(...skipping 863 matching lines...) Expand 10 before | Expand all | Expand 10 after
2104 2106
2105 2107
2106 void HCheckPrototypeMaps::Verify() { 2108 void HCheckPrototypeMaps::Verify() {
2107 HInstruction::Verify(); 2109 HInstruction::Verify();
2108 ASSERT(HasNoUses()); 2110 ASSERT(HasNoUses());
2109 } 2111 }
2110 2112
2111 #endif 2113 #endif
2112 2114
2113 } } // namespace v8::internal 2115 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/hydrogen-instructions.h ('k') | src/runtime.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698