src/hydrogen-instructions.cc - Issue 8914006: Create missing boilerplate for array literals instead of deoptimizing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen-instructions.cc

Issue 8914006: Create missing boilerplate for array literals instead of deoptimizing (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: address comments Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/hydrogen-instructions.cc

diff --git a/src/hydrogen-instructions.cc b/src/hydrogen-instructions.cc

index 31d7d153f9b36a51ccef8ad76609bcb0a54debfd..1ff7f16fdf4195f19184eefe8c72093db641c71d 100644

--- a/src/hydrogen-instructions.cc

+++ b/src/hydrogen-instructions.cc

@@ -1227,7 +1227,9 @@ void HConstant::PrintDataTo(StringStream* stream) {

bool HArrayLiteral::IsCopyOnWrite() const {

- return boilerplate_object_->elements()->map() == HEAP->fixed_cow_array_map();

+ if (!boilerplate_object_->IsJSObject()) return false;

+ return Handle<JSObject>::cast(boilerplate_object_)->elements()->map() ==

+ HEAP->fixed_cow_array_map();

}

« no previous file with comments | « src/hydrogen-instructions.h ('k') | src/runtime.h » ('j') | no next file with comments »