Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 8907016: Spellchecker should recheck after changing language. (Closed)

Created:
9 years ago by shinyak
Modified:
8 years, 2 months ago
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, brettw-cc_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, ajwong+watch_chromium.org
Visibility:
Public.

Description

This patch introduces a code to request spell checking after changing language. In http://trac.webkit.org/changeset/105489, we have added a webkit interface to request spell checking from chromium. This patch calls the API when we the spellcheck language is changed. BUG=21225 TEST=MANUAL

Patch Set 1 #

Patch Set 2 : Patch #

Patch Set 3 : Patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
M chrome/browser/tab_contents/spellchecker_submenu_observer_hunspell.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M content/common/view_messages.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
shinyak
Hi, I've implemented a patch to recheck spelling when changing spellcheck language. I think this ...
8 years, 10 months ago (2012-01-30 07:05:19 UTC) #1
Avi (use Gerrit)
I'd like John to take a look at this. We've tended to keep spellchecking out ...
8 years, 10 months ago (2012-02-01 15:48:00 UTC) #2
jam
On 2012/02/01 15:48:00, Avi wrote: > I'd like John to take a look at this. ...
8 years, 10 months ago (2012-02-01 17:15:16 UTC) #3
James Cook
-jamescook. I don't really know this code.
8 years, 10 months ago (2012-02-01 18:13:31 UTC) #4
jeremy
8 years, 10 months ago (2012-02-06 05:46:31 UTC) #5
This code should be #ifdef-ed out on OS X since it's only needed when using
Hunspell and not applicable for using the native OS X spellchecker (see comment
#49 on crbug.com/21225) .

Powered by Google App Engine
This is Rietveld 408576698