Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: chrome/browser/tab_contents/spellchecker_submenu_observer_hunspell.cc

Issue 8907016: Spellchecker should recheck after changing language. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Patch Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/renderer_host/render_widget_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/tab_contents/spellchecker_submenu_observer_hunspell.cc
diff --git a/chrome/browser/tab_contents/spellchecker_submenu_observer_hunspell.cc b/chrome/browser/tab_contents/spellchecker_submenu_observer_hunspell.cc
index 5a750b25dd9b0a1f58d65dcdcdf76fa69997c0a9..706d41cc2bda5a3ccc9605497268aa33aa30bd73 100644
--- a/chrome/browser/tab_contents/spellchecker_submenu_observer_hunspell.cc
+++ b/chrome/browser/tab_contents/spellchecker_submenu_observer_hunspell.cc
@@ -168,6 +168,8 @@ bool SpellCheckerSubMenuObserver::IsCommandIdEnabled(int command_id) {
void SpellCheckerSubMenuObserver::ExecuteCommand(int command_id) {
DCHECK(IsCommandIdSupported(command_id));
+ RenderViewHost* rvh = proxy_->GetRenderViewHost();
+
// Check to see if one of the spell check language ids have been clicked.
if (command_id >= IDC_SPELLCHECK_LANGUAGES_FIRST &&
command_id < IDC_SPELLCHECK_LANGUAGES_LAST) {
@@ -179,11 +181,11 @@ void SpellCheckerSubMenuObserver::ExecuteCommand(int command_id) {
profile->GetPrefs(),
NULL);
dictionary_language.SetValue(languages_[language]);
+ rvh->RequestTextChecking();
}
return;
}
- RenderViewHost* rvh = proxy_->GetRenderViewHost();
switch (command_id) {
case IDC_CHECK_SPELLING_OF_THIS_FIELD:
rvh->Send(new SpellCheckMsg_ToggleSpellCheck(rvh->routing_id()));
« no previous file with comments | « no previous file | content/browser/renderer_host/render_widget_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698