Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 8898027: Revert 114083 - Convert app_launch_index and page_index from int to StringOrdinal. (Closed)

Created:
9 years ago by csharp
Modified:
9 years ago
Reviewers:
csharp
CC:
chromium-reviews, jstritar+watch_chromium.org, ncarter (slow), jennb, akalin, prasadt, Raghu Simha, mihaip+watch_chromium.org, dcheng, Dmitry Titov, Aaron Boodman, arv (Not doing code reviews), jianli, Paweł Hajdan Jr., estade+watch_chromium.org, tim (not reviewing)
Visibility:
Public.

Description

Revert 114083 - Convert app_launch_index and page_index from int to StringOrdinal. This application icon index values are being changed from ints to StringOrdinals to decrease the potential number of syncs required when icons are moved, by only needing to change 1 StringOrdinal instead of all the integers. BUG=61447 TEST=Open up an instance of chromium with multiple application icons and ensure that icons can still have their page and order changed. There should be no behaviour change. Review URL: http://codereview.chromium.org/8198003 TBR=csharp@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114257

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -711 lines) Patch
M chrome/browser/extensions/crx_installer.h View 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/extensions/crx_installer.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/extension_prefs.h View 6 chunks +25 lines, -96 lines 0 comments Download
M chrome/browser/extensions/extension_prefs.cc View 8 chunks +61 lines, -291 lines 0 comments Download
M chrome/browser/extensions/extension_prefs_unittest.cc View 6 chunks +40 lines, -191 lines 0 comments Download
MM chrome/browser/extensions/extension_service.h View 1 chunk +1 line, -3 lines 0 comments Download
MM chrome/browser/extensions/extension_service.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/extensions/test_extension_prefs.cc View 1 chunk +1 line, -2 lines 0 comments Download
MM chrome/browser/extensions/unpacked_installer.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/resources/ntp4/page_list_view.js View 1 chunk +2 lines, -2 lines 0 comments Download
MM chrome/browser/sync/test/integration/sync_extension_helper.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/panels/base_panel_browser_test.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/app_launcher_handler.h View 2 chunks +1 line, -5 lines 0 comments Download
MM chrome/browser/ui/webui/ntp/app_launcher_handler.cc View 10 chunks +33 lines, -57 lines 0 comments Download
M chrome/common/string_ordinal.h View 3 chunks +0 lines, -14 lines 0 comments Download
M chrome/common/string_ordinal.cc View 3 chunks +0 lines, -15 lines 0 comments Download
M chrome/common/string_ordinal_unittest.cc View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
csharp
9 years ago (2011-12-13 20:08:29 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698