Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: chrome/common/string_ordinal.cc

Issue 8898027: Revert 114083 - Convert app_launch_index and page_index from int to StringOrdinal. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/string_ordinal.h ('k') | chrome/common/string_ordinal_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/string_ordinal.cc
===================================================================
--- chrome/common/string_ordinal.cc (revision 114254)
+++ chrome/common/string_ordinal.cc (working copy)
@@ -174,10 +174,6 @@
is_valid_(false) {
}
-StringOrdinal StringOrdinal::CreateInitialOrdinal() {
- return StringOrdinal(std::string(1, kMidDigit));
-}
-
bool StringOrdinal::IsValid() const {
return is_valid_;
}
@@ -188,12 +184,6 @@
return string_ordinal_ < other.string_ordinal_;
}
-bool StringOrdinal::GreaterThan(const StringOrdinal& other) const {
- CHECK(IsValid());
- CHECK(other.IsValid());
- return string_ordinal_ > other.string_ordinal_;
-}
-
bool StringOrdinal::Equal(const StringOrdinal& other) const {
CHECK(IsValid());
CHECK(other.IsValid());
@@ -248,8 +238,3 @@
CHECK(IsValid());
return string_ordinal_;
}
-
-bool StringOrdinalLessThan::operator() (const StringOrdinal& lhs,
- const StringOrdinal& rhs) const {
- return lhs.LessThan(rhs);
-}
« no previous file with comments | « chrome/common/string_ordinal.h ('k') | chrome/common/string_ordinal_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698