Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Side by Side Diff: chrome/common/string_ordinal_unittest.cc

Issue 8898027: Revert 114083 - Convert app_launch_index and page_index from int to StringOrdinal. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/common/string_ordinal.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/string_ordinal.h" 5 #include "chrome/common/string_ordinal.h"
6 #include "testing/gtest/include/gtest/gtest.h" 6 #include "testing/gtest/include/gtest/gtest.h"
7 7
8 namespace { 8 namespace {
9 9
10 TEST(StringOrdinalTest, IsValid) { 10 TEST(StringOrdinalTest, IsValid) {
(...skipping 11 matching lines...) Expand all
22 22
23 EXPECT_TRUE(small_value.LessThan(middle_value)); 23 EXPECT_TRUE(small_value.LessThan(middle_value));
24 EXPECT_TRUE(small_value.LessThan(big_value)); 24 EXPECT_TRUE(small_value.LessThan(big_value));
25 EXPECT_TRUE(middle_value.LessThan(big_value)); 25 EXPECT_TRUE(middle_value.LessThan(big_value));
26 26
27 EXPECT_FALSE(big_value.LessThan(small_value)); 27 EXPECT_FALSE(big_value.LessThan(small_value));
28 EXPECT_FALSE(big_value.LessThan(middle_value)); 28 EXPECT_FALSE(big_value.LessThan(middle_value));
29 EXPECT_FALSE(middle_value.LessThan(small_value)); 29 EXPECT_FALSE(middle_value.LessThan(small_value));
30 } 30 }
31 31
32 TEST(StringOrdinalTest, GreaterThan) {
33 StringOrdinal small_value("b");
34 StringOrdinal middle_value("n");
35 StringOrdinal big_value("z");
36
37 EXPECT_TRUE(big_value.GreaterThan(small_value));
38 EXPECT_TRUE(big_value.GreaterThan(middle_value));
39 EXPECT_TRUE(middle_value.GreaterThan(small_value));
40
41
42 EXPECT_FALSE(small_value.GreaterThan(middle_value));
43 EXPECT_FALSE(small_value.GreaterThan(big_value));
44 EXPECT_FALSE(middle_value.GreaterThan(big_value));
45 }
46
47
48 // Tests the CreateBetween StringOrdinal function by calling 32 // Tests the CreateBetween StringOrdinal function by calling
49 // on the small_value with the large_value as the parameter and 33 // on the small_value with the large_value as the parameter and
50 // vice-versa. 34 // vice-versa.
51 void TestCreateBetween(StringOrdinal small_value, 35 void TestCreateBetween(StringOrdinal small_value,
52 StringOrdinal large_value, 36 StringOrdinal large_value,
53 const std::string& expected_result) { 37 const std::string& expected_result) {
54 StringOrdinal result = small_value.CreateBetween(large_value); 38 StringOrdinal result = small_value.CreateBetween(large_value);
55 EXPECT_EQ(expected_result, result.ToString()); 39 EXPECT_EQ(expected_result, result.ToString());
56 40
57 result = large_value.CreateBetween(small_value); 41 result = large_value.CreateBetween(small_value);
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
123 StringOrdinal index("b"); 107 StringOrdinal index("b");
124 EXPECT_EQ(index.ToString(), "b"); 108 EXPECT_EQ(index.ToString(), "b");
125 109
126 index = StringOrdinal("aab"); 110 index = StringOrdinal("aab");
127 EXPECT_EQ(index.ToString(), "aab"); 111 EXPECT_EQ(index.ToString(), "aab");
128 112
129 index = StringOrdinal("zzz"); 113 index = StringOrdinal("zzz");
130 EXPECT_EQ(index.ToString(), "zzz"); 114 EXPECT_EQ(index.ToString(), "zzz");
131 } 115 }
132 } // namespace 116 } // namespace
OLDNEW
« no previous file with comments | « chrome/common/string_ordinal.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698