Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 8897008: Download SwiftShader component if WebGL is blacklisted (Closed)

Created:
9 years ago by jbauman
Modified:
9 years ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, laforge
Visibility:
Public.

Description

Download SwiftShader component if WebGL is blacklisted Register with the component updater service if it's discovered that WebGL is blacklisted. Then register the swiftshader library with the GPU data manager. BUG=26001 TEST=Start up chrome on a blacklisted windows machine, wait a while, and open a webgl page Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114885

Patch Set 1 #

Total comments: 3

Patch Set 2 : small changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+239 lines, -0 lines) Patch
M build/common.gypi View 1 1 chunk +3 lines, -0 lines 0 comments Download
A chrome/browser/component_updater/swiftshader_component_installer.h View 1 chunk +17 lines, -0 lines 0 comments Download
A chrome/browser/component_updater/swiftshader_component_installer.cc View 1 1 chunk +215 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_init.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jbauman
9 years ago (2011-12-09 20:30:27 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm Some nits below. http://codereview.chromium.org/8897008/diff/1/chrome/browser/component_updater/swiftshader_component_installer.cc File chrome/browser/component_updater/swiftshader_component_installer.cc (right): http://codereview.chromium.org/8897008/diff/1/chrome/browser/component_updater/swiftshader_component_installer.cc#newcode80 chrome/browser/component_updater/swiftshader_component_installer.cc:80: remove space http://codereview.chromium.org/8897008/diff/1/chrome/browser/component_updater/swiftshader_component_installer.cc#newcode187 chrome/browser/component_updater/swiftshader_component_installer.cc:187: UpdateChecker ...
9 years ago (2011-12-13 20:09:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/8897008/5001
9 years ago (2011-12-16 19:30:45 UTC) #3
commit-bot: I haz the power
Try job failure for 8897008-5001 (retry) on win_rel for step "ui_tests". It's a second try, ...
9 years ago (2011-12-16 22:10:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/8897008/5001
9 years ago (2011-12-16 22:22:21 UTC) #5
commit-bot: I haz the power
9 years ago (2011-12-16 23:49:45 UTC) #6
Try job failure for 8897008-5001 (retry) on linux_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Powered by Google App Engine
This is Rietveld 408576698