Aura: Add --aura-laptop-mode to fill the workspace with a single window.

Aura: Add --aura-laptop-mode to fill the workspace with a single window.

This is the first of several CLs to add a "laptop mode" to Aura that works like the traditional ChromeOS browser view.  In particular:
* Keep the browser maximized.
* Hide window caption buttons.
* Suppress the launcher and related shelf items.
* Suppress background image.
* Add the switch to about:flags.

These things don't work yet:
* Status area is wedged in upper-left corner.
* Popup browser windows are maximized and they shouldn't be.

BUG=106898
TEST=manual, run ChromeOS Aura build and turn the flag on and off

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114527

[James Cook, 2011-12-10 00:50:06]

Oshima, PTAL at chrome/* especially opaque_browser_frame_view.cc

Sky, PTAL at aura/* and aura_shell/*

Thanks!

[sky, 2011-12-12 15:46:28]

http://codereview.chromium.org/8895003/diff/16/chrome/browser/ui/views/aura/c...
File chrome/browser/ui/views/aura/chrome_shell_delegate.cc (right):

http://codereview.chromium.org/8895003/diff/16/chrome/browser/ui/views/aura/c...
chrome/browser/ui/views/aura/chrome_shell_delegate.cc:13: #include
"ui/aura_shell/shell.h"
sort

http://codereview.chromium.org/8895003/diff/16/chrome/browser/ui/views/aura/c...
chrome/browser/ui/views/aura/chrome_shell_delegate.cc:37: if
(!aura_shell::Shell::GetInstance()->launcher())
It doesn't seem like you create the launcher, so that this shouldn't be
necessary. Are you sure this is needed?

http://codereview.chromium.org/8895003/diff/16/chrome/browser/ui/views/frame/...
File chrome/browser/ui/views/frame/opaque_browser_frame_view.cc (right):

http://codereview.chromium.org/8895003/diff/16/chrome/browser/ui/views/frame/...
chrome/browser/ui/views/frame/opaque_browser_frame_view.cc:1025: #if
defined(USE_AURA)
How about a IsSingleWindow() on BrowserFrame?

http://codereview.chromium.org/8895003/diff/16/ui/aura_shell/shell.cc
File ui/aura_shell/shell.cc (right):

http://codereview.chromium.org/8895003/diff/16/ui/aura_shell/shell.cc#newcode60
ui/aura_shell/shell.cc:60: new ToplevelWindowEventFilter(default_container));
Don't you want a different ToplevelWindowEventFilter too?

[James Cook, 2011-12-12 18:33:36]

Updated.

http://codereview.chromium.org/8895003/diff/16/chrome/browser/ui/views/aura/c...
File chrome/browser/ui/views/aura/chrome_shell_delegate.cc (right):

http://codereview.chromium.org/8895003/diff/16/chrome/browser/ui/views/aura/c...
chrome/browser/ui/views/aura/chrome_shell_delegate.cc:13: #include
"ui/aura_shell/shell.h"
On 2011/12/12 15:46:29, sky wrote:
> sort

Done.

http://codereview.chromium.org/8895003/diff/16/chrome/browser/ui/views/aura/c...
chrome/browser/ui/views/aura/chrome_shell_delegate.cc:37: if
(!aura_shell::Shell::GetInstance()->launcher())
On 2011/12/12 15:46:29, sky wrote:
> It doesn't seem like you create the launcher, so that this shouldn't be
> necessary. Are you sure this is needed?

I was using this to avoid a null-check in BrowserView.  I moved it there, which
seems more clear.

http://codereview.chromium.org/8895003/diff/16/chrome/browser/ui/views/frame/...
File chrome/browser/ui/views/frame/opaque_browser_frame_view.cc (right):

http://codereview.chromium.org/8895003/diff/16/chrome/browser/ui/views/frame/...
chrome/browser/ui/views/frame/opaque_browser_frame_view.cc:1025: #if
defined(USE_AURA)
On 2011/12/12 15:46:29, sky wrote:
> How about a IsSingleWindow() on BrowserFrame?

Oh, good idea!  Done.

http://codereview.chromium.org/8895003/diff/16/ui/aura_shell/shell.cc
File ui/aura_shell/shell.cc (right):

http://codereview.chromium.org/8895003/diff/16/ui/aura_shell/shell.cc#newcode60
ui/aura_shell/shell.cc:60: new ToplevelWindowEventFilter(default_container));
On 2011/12/12 15:46:29, sky wrote:
> Don't you want a different ToplevelWindowEventFilter too?

Hmm.  If we want popups to be draggable windows, we need the existing event
filter.  But if not, we don't need a filter at all (the existing one only does
dragging).  I'll suppress creating of this filter for laptop mode.

[sky, 2011-12-12 21:37:19]

LGTM

[James Cook, 2011-12-12 21:40:17]

On 2011/12/12 21:37:19, sky wrote:
> LGTM

Ping Oshima for chrome/* ?

[oshima, 2011-12-13 00:27:16]

Sorry for delay, looking now.

On Mon, Dec 12, 2011 at 1:40 PM, <jamescook@chromium.org> wrote:

> On 2011/12/12 21:37:19, sky wrote:
>
>> LGTM
>>
>
> Ping Oshima for chrome/* ?
>
>
http://codereview.chromium.**org/8895003/<http://codereview.chromium.org/8895...
>

[oshima, 2011-12-13 00:47:42]

one general comment. Existing chromeos is not maximizing via WM (thus, the logic
is a bit complicated) because doing so creates artifacts that the browser window
is showing up in normal window first and then gets maximized. 
 I believe this isn't an issue with aura and I'm wondering if we should simply
maximize the browser window.

http://codereview.chromium.org/8895003/diff/9001/chrome/browser/ui/views/fram...
File chrome/browser/ui/views/frame/browser_frame.cc (right):

http://codereview.chromium.org/8895003/diff/9001/chrome/browser/ui/views/fram...
chrome/browser/ui/views/frame/browser_frame.cc:72: // TODO(jamescook): Do this
for Aura laptop mode?
you probably want to do this for laptop mode.

http://codereview.chromium.org/8895003/diff/9001/chrome/browser/ui/views/fram...
File chrome/browser/ui/views/frame/browser_frame.h (right):

http://codereview.chromium.org/8895003/diff/9001/chrome/browser/ui/views/fram...
chrome/browser/ui/views/frame/browser_frame.h:72: bool IsSingleWindowMode()
const;
I wonder if there is better name for this. I dont have good suggestion and no
need to change this now though.

[James Cook, 2011-12-13 18:19:12]

Oshima, please take another look.

http://codereview.chromium.org/8895003/diff/9001/chrome/browser/ui/views/fram...
File chrome/browser/ui/views/frame/browser_frame.cc (right):

http://codereview.chromium.org/8895003/diff/9001/chrome/browser/ui/views/fram...
chrome/browser/ui/views/frame/browser_frame.cc:72: // TODO(jamescook): Do this
for Aura laptop mode?
On 2011/12/13 00:47:47, oshima wrote:
> you probably want to do this for laptop mode.

Done.

http://codereview.chromium.org/8895003/diff/9001/chrome/browser/ui/views/fram...
chrome/browser/ui/views/frame/browser_frame.cc:124: bool
BrowserFrame::IsMaximized() const {
I reverted this to the old way, and made it so tabbed browser windows always
start maximized in laptop mode.  I still had some initial resize junk (black in
the content area while the content resizes) so I still need to override the
bounds in the layout manager, but this seems better.

http://codereview.chromium.org/8895003/diff/9001/chrome/browser/ui/views/fram...
File chrome/browser/ui/views/frame/browser_frame.h (right):

http://codereview.chromium.org/8895003/diff/9001/chrome/browser/ui/views/fram...
chrome/browser/ui/views/frame/browser_frame.h:72: bool IsSingleWindowMode()
const;
On 2011/12/13 00:47:47, oshima wrote:
> I wonder if there is better name for this. I dont have good suggestion and no
> need to change this now though.

Yeah, I wish I had a better name also.  I'm trying to avoid words like
"fullscreen" and "maximized" that have specific meanings elsewhere.  If you
think of one please let me know.

[oshima, 2011-12-14 17:41:02]

http://codereview.chromium.org/8895003/diff/21001/chrome/browser/ui/views/fra...
File chrome/browser/ui/views/frame/opaque_browser_frame_view.cc (right):

http://codereview.chromium.org/8895003/diff/21001/chrome/browser/ui/views/fra...
chrome/browser/ui/views/frame/opaque_browser_frame_view.cc:957: if (is_maximized
|| frame()->IsFullscreen()) {
just a comment and no need for change.
This was to allow chrome for chromeos to run on desktop with window control
buttons. With aura, we can emulate most of chromeos behavior, we may want to
remove this when we kill gtk version.

http://codereview.chromium.org/8895003/diff/21001/ui/aura_shell/laptop_mode_l...
File ui/aura_shell/laptop_mode_layout_manager.cc (right):

http://codereview.chromium.org/8895003/diff/21001/ui/aura_shell/laptop_mode_l...
ui/aura_shell/laptop_mode_layout_manager.cc:51: if (child->type() ==
aura::WINDOW_TYPE_NORMAL)
since you're now setting show state, shouldn't you check the show state?

[James Cook, 2011-12-14 18:24:36]

Oshima, PTAL.

http://codereview.chromium.org/8895003/diff/21001/ui/aura_shell/laptop_mode_l...
File ui/aura_shell/laptop_mode_layout_manager.cc (right):

http://codereview.chromium.org/8895003/diff/21001/ui/aura_shell/laptop_mode_l...
ui/aura_shell/laptop_mode_layout_manager.cc:51: if (child->type() ==
aura::WINDOW_TYPE_NORMAL)
On 2011/12/14 17:41:02, oshima wrote:
> since you're now setting show state, shouldn't you check the show state?

Ah, good point. Done.

[oshima, 2011-12-14 18:28:36]

lgtm