Aura: Add --aura-laptop-mode to fill the workspace with a single window.

chrome/browser/ui/views/frame/browser_frame.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/browser_frame.h"
 
 #include "base/command_line.h"
 #include "chrome/browser/themes/theme_service.h"
 #include "chrome/browser/themes/theme_service_factory.h"
 #include "chrome/browser/ui/browser.h"
@@ skipping 51 matching lines @@
     // from being changed to top-most after the window is created without
     // activation.
     params.keep_on_top = true;
   }
 #if defined(USE_AURA)
   CommandLine* command_line = CommandLine::ForCurrentProcess();
   if (command_line->HasSwitch(switches::kAuraTranslucentFrames))
     params.transparent = true;
 #endif
   Init(params);
+  // TODO(jamescook): Do this for Aura laptop mode?

[oshima, 2011/12/13 00:47:47]

you probably want to do this for laptop mode.

[James Cook, 2011/12/13 18:19:13]

Done.

 #if defined(OS_CHROMEOS) && !defined(USE_AURA)
   // On ChromeOS we always want top-level windows to appear active.
   if (!browser_view_->IsBrowserTypePopup())
     DisableInactiveRendering();
 #endif
 }
 
 int BrowserFrame::GetMinimizeButtonOffset() const {
   return native_browser_frame_->GetMinimizeButtonOffset();
 }
@@ skipping 16 matching lines @@
 
 void BrowserFrame::TabStripDisplayModeChanged() {
   if (GetRootView()->has_children()) {
     // Make sure the child of the root view gets Layout again.
     GetRootView()->child_at(0)->InvalidateLayout();
   }
   GetRootView()->Layout();
   native_browser_frame_->TabStripDisplayModeChanged();
 }
 
+bool BrowserFrame::IsSingleWindowMode() const {
+  bool single_window_mode = false;
+#if defined(USE_AURA)
+  single_window_mode =
+      CommandLine::ForCurrentProcess()->HasSwitch(switches::kAuraLaptopMode);
+#elif defined(OS_CHROMEOS)
+  single_window_mode =
+      chromeos::system::runtime_environment::IsRunningOnChromeOS();
+#endif
+  return single_window_mode;
+}
+
 ///////////////////////////////////////////////////////////////////////////////
-// BrowserFrameWin, views::Window overrides:
+// BrowserFrame, views::Widget overrides:
 
 bool BrowserFrame::IsMaximized() const {

[James Cook, 2011/12/13 18:19:13]

I reverted this to the old way, and made it so tabbed browser windows always
start maximized in laptop mode.  I still had some initial resize junk (black in
the content area while the content resizes) so I still need to override the
bounds in the layout manager, but this seems better.

-#if defined(OS_CHROMEOS) && !defined(USE_AURA)
-  if (chromeos::system::runtime_environment::IsRunningOnChromeOS()) {
+  if (IsSingleWindowMode()) {
     return !IsFullscreen() &&
         (!browser_view_->IsBrowserTypePopup() || Widget::IsMaximized());
   }
-#endif
   return Widget::IsMaximized();
 }
 
 views::internal::RootView* BrowserFrame::CreateRootView() {
   root_view_ = new BrowserRootView(browser_view_, this);
   return root_view_;
 }
 
 views::NonClientFrameView* BrowserFrame::CreateNonClientFrameView() {
 #if defined(OS_WIN) && !defined(USE_AURA)
@@ skipping 28 matching lines @@
     // set ourselves as the last active browser window to ensure that we get
     // treated as such by the rest of Chrome.
     BrowserList::SetLastActive(browser_view_->browser());
   }
   Widget::OnNativeWidgetActivationChanged(active);
 }
 
 AvatarMenuButton* BrowserFrame::GetAvatarMenuButton() {
   return browser_frame_view_->avatar_button();
 }