Issue 8888018: Remove TODOs about TryCatch not working.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8888018: Remove TODOs about TryCatch not working. (Closed)

Created:
9 years ago by brettw

Modified:
9 years ago

Reviewers:
dmichael (off chromium)

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove TODOs about TryCatch not working. This doesn't make sense to fix since it's just a private API. BUG=54011 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113667

Patch Set 1 #

Total comments: 1

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	ppapi/tests/test_instance_deprecated.cc	View		1 chunk	+3 lines, -3 lines	1 comment	Download
	M	webkit/plugins/ppapi/ppapi_plugin_instance.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

dmichael (off chromium)

9 years ago (2011-12-08 18:39:08 UTC) #2

lgtm

http://codereview.chromium.org/8888018/diff/1/ppapi/tests/test_instance_depre...
File ppapi/tests/test_instance_deprecated.cc (right):

http://codereview.chromium.org/8888018/diff/1/ppapi/tests/test_instance_depre...
ppapi/tests/test_instance_deprecated.cc:112: // get pass the strings up. Since
this is a trusted only interface, we've
nit: remove 'get '

Expand Messages | Collapse Messages