Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(879)

Unified Diff: webkit/plugins/ppapi/ppapi_plugin_instance.cc

Issue 8888018: Remove TODOs about TryCatch not working. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/plugins/ppapi/ppapi_plugin_instance.cc
diff --git a/webkit/plugins/ppapi/ppapi_plugin_instance.cc b/webkit/plugins/ppapi/ppapi_plugin_instance.cc
index 3d75d86c0754e4d4a9806f192f20d577532ea4f0..ed4218023704e26b0b53ec9a243d57e7432ce0f5 100644
--- a/webkit/plugins/ppapi/ppapi_plugin_instance.cc
+++ b/webkit/plugins/ppapi/ppapi_plugin_instance.cc
@@ -1717,8 +1717,8 @@ PP_Var PluginInstance::ExecuteScript(PP_Instance instance,
bool ok = WebBindings::evaluate(NULL, frame->windowObject(), &np_script,
&result);
if (!ok) {
- // TODO(brettw) bug 54011: The TryCatch isn't working properly and
- // doesn't actually catch this exception.
+ // TryCatch doesn't catch the exceptions properly. Since this is only for
+ // a trusted API, just set to a general exception message.
try_catch.SetException("Exception caught");
WebBindings::releaseVariantValue(&result);
return PP_MakeUndefined();
« ppapi/tests/test_instance_deprecated.cc ('K') | « ppapi/tests/test_instance_deprecated.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698