Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Unified Diff: ppapi/tests/test_instance_deprecated.cc

Issue 8888018: Remove TODOs about TryCatch not working. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webkit/plugins/ppapi/ppapi_plugin_instance.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/tests/test_instance_deprecated.cc
diff --git a/ppapi/tests/test_instance_deprecated.cc b/ppapi/tests/test_instance_deprecated.cc
index a62f20251b790d178818576a4d382b2a0f0727c3..7c7c91c7940b05a2de3c273c49f0d1cf324ef834 100644
--- a/ppapi/tests/test_instance_deprecated.cc
+++ b/ppapi/tests/test_instance_deprecated.cc
@@ -108,9 +108,9 @@ std::string TestInstance::TestExecuteScript() {
&exception);
ASSERT_TRUE(ret.is_undefined());
ASSERT_TRUE(exception.is_string());
- // TODO(brettw) bug 54011: The TryCatch isn't working properly and
- // doesn't actually pass the exception text up.
- //ASSERT_TRUE(exception.AsString() == "plugin exception");
+ // Due to a limitation in the implementation of TryCatch, it doesn't actually
+ // get pass the strings up. Since this is a trusted only interface, we've
dmichael (off chromium) 2011/12/08 18:39:08 nit: remove 'get '
+ // decided not to bother fixing this for now.
// Exception caused by string evaluation should be caught.
exception = pp::Var();
« no previous file with comments | « no previous file | webkit/plugins/ppapi/ppapi_plugin_instance.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698