First instantiations of objects.

First instantiations of objects.

Committed: https://code.google.com/p/dart/source/detail?r=2254

[floitsch, 2011-12-08 15:25:37]

Sample output:

class A { A() {} }
main() { new A(); }

=>


function Isolate() {};

Isolate.prototype.A = function() {};
Isolate.prototype.A.prototype.default = function() {
};
Isolate.prototype.$default = function() {
  var t0 = new currentIsolate.A();
  t0.default();
  return t0;
};
Isolate.prototype.main = function() {
  currentIsolate.$default();
};

var currentIsolate = new Isolate();
currentIsolate.main();

[ngeoffray, 2011-12-08 16:01:40]

LGTM!

http://codereview.chromium.org/8888010/diff/2001/frog/leg/elements/elements.dart
File frog/leg/elements/elements.dart (right):

http://codereview.chromium.org/8888010/diff/2001/frog/leg/elements/elements.d...
frog/leg/elements/elements.dart:193: List<Element> backendMembers;
Please make that a Link.

http://codereview.chromium.org/8888010/diff/2001/frog/leg/namer.dart
File frog/leg/namer.dart (right):

http://codereview.chromium.org/8888010/diff/2001/frog/leg/namer.dart#newcode32
frog/leg/namer.dart:32: String dartId = '${element.name}';
Please add a method getName that takes an element, and returns 'default' if the
name is empty. And use that method here and in instanceName.

http://codereview.chromium.org/8888010/diff/2001/frog/leg/namer.dart#newcode34
frog/leg/namer.dart:34: assert(element is FunctionElement);
element.kind == ElementKind.CONSTRUCTOR?

http://codereview.chromium.org/8888010/diff/2001/frog/leg/namer.dart#newcode76
frog/leg/namer.dart:76: if (element is ConstructorBodyElement) {
element.kind == ElementKind.CONSTRUCTOR_BODY

http://codereview.chromium.org/8888010/diff/2001/frog/leg/namer.dart#newcode83
frog/leg/namer.dart:83: String constructorBodyName(Element element) {
assert(element.kind == ElementKind.BODY_CONSTRUCTOR)?

http://codereview.chromium.org/8888010/diff/2001/frog/leg/ssa/builder.dart
File frog/leg/ssa/builder.dart (right):

http://codereview.chromium.org/8888010/diff/2001/frog/leg/ssa/builder.dart#ne...
frog/leg/ssa/builder.dart:17: graph = compileConstructor(builder, function,
element, elements);
I wouuld have the same API between compileConstructor* and compileMethod.
Passing in the builder and the element.

http://codereview.chromium.org/8888010/diff/2001/frog/leg/ssa/builder.dart#ne...
frog/leg/ssa/builder.dart:113: if (superInvocation !== null) {
I'm not really fund of having code that we know is not executed. Please add a
unimplemented just before this code.

http://codereview.chromium.org/8888010/diff/2001/frog/leg/ssa/builder.dart#ne...
frog/leg/ssa/builder.dart:669: visitSend(node.send);
=> syntax?

[floitsch, 2011-12-08 16:35:59]

http://codereview.chromium.org/8888010/diff/2001/frog/leg/elements/elements.dart
File frog/leg/elements/elements.dart (right):

http://codereview.chromium.org/8888010/diff/2001/frog/leg/elements/elements.d...
frog/leg/elements/elements.dart:193: List<Element> backendMembers;
On 2011/12/08 16:01:40, ngeoffray wrote:
> Please make that a Link.

Done.

http://codereview.chromium.org/8888010/diff/2001/frog/leg/namer.dart
File frog/leg/namer.dart (right):

http://codereview.chromium.org/8888010/diff/2001/frog/leg/namer.dart#newcode32
frog/leg/namer.dart:32: String dartId = '${element.name}';
On 2011/12/08 16:01:40, ngeoffray wrote:
> Please add a method getName that takes an element, and returns 'default' if
the
> name is empty. And use that method here and in instanceName.

Done.

http://codereview.chromium.org/8888010/diff/2001/frog/leg/namer.dart#newcode34
frog/leg/namer.dart:34: assert(element is FunctionElement);
On 2011/12/08 16:01:40, ngeoffray wrote:
> element.kind == ElementKind.CONSTRUCTOR?

Done.

http://codereview.chromium.org/8888010/diff/2001/frog/leg/namer.dart#newcode76
frog/leg/namer.dart:76: if (element is ConstructorBodyElement) {
On 2011/12/08 16:01:40, ngeoffray wrote:
> element.kind == ElementKind.CONSTRUCTOR_BODY

Done.

http://codereview.chromium.org/8888010/diff/2001/frog/leg/namer.dart#newcode83
frog/leg/namer.dart:83: String constructorBodyName(Element element) {
On 2011/12/08 16:01:40, ngeoffray wrote:
> assert(element.kind == ElementKind.BODY_CONSTRUCTOR)?
Actually it must be a constructor. This is necessary, as we need to get to the
body-constructor from a constructor when we call 'super'.
Added comment and assert.

http://codereview.chromium.org/8888010/diff/2001/frog/leg/ssa/builder.dart
File frog/leg/ssa/builder.dart (right):

http://codereview.chromium.org/8888010/diff/2001/frog/leg/ssa/builder.dart#ne...
frog/leg/ssa/builder.dart:17: graph = compileConstructor(builder, function,
element, elements);
On 2011/12/08 16:01:40, ngeoffray wrote:
> I wouuld have the same API between compileConstructor* and compileMethod.
> Passing in the builder and the element.

Done.

http://codereview.chromium.org/8888010/diff/2001/frog/leg/ssa/builder.dart#ne...
frog/leg/ssa/builder.dart:113: if (superInvocation !== null) {
On 2011/12/08 16:01:40, ngeoffray wrote:
> I'm not really fund of having code that we know is not executed. Please add a
> unimplemented just before this code.

Done.

http://codereview.chromium.org/8888010/diff/2001/frog/leg/ssa/builder.dart#ne...
frog/leg/ssa/builder.dart:669: visitSend(node.send);
On 2011/12/08 16:01:40, ngeoffray wrote:
> => syntax?

Done.