First instantiations of objects.

frog/leg/namer.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Assigns JavaScript identifiers to Dart variables, class-names and members.
  */
 class Namer {
   static Set<String> _jsReserved = null;
   Set<String> get jsReserved() {
@@ skipping 11 matching lines @@
   Namer()
       : globals = new Map<Element, String>(),
         usedGlobals = new Map<String, int>();
 
   String get currentIsolate() => "currentIsolate";
   String get isolate() => "Isolate";
 
   String define(Element element) {
     assert(globals[element] === null);
 
     String dartId = '${element.name}';

[ngeoffray, 2011/12/08 16:01:40]

Please add a method getName that takes an element, and returns 'default' if the
name is empty. And use that method here and in instanceName.

[floitsch, 2011/12/08 16:36:00]

Done.

+    if (dartId == '') {
+      assert(element is FunctionElement);

[ngeoffray, 2011/12/08 16:01:40]

element.kind == ElementKind.CONSTRUCTOR?

[floitsch, 2011/12/08 16:36:00]

Done.

+      dartId = 'default';
+    }
     // Prefix the dartId with '$' if the name is reserved.
     if (jsReserved.contains(dartId)) {
       dartId = "\$$dartId";
       assert(!jsReserved.contains(dartId));
     }
 
     int usedCount = usedGlobals[dartId];
     if (usedCount === null) {
       // No element with this name has been used before.
       usedGlobals[dartId] = 1;
       globals[element] = dartId;
       return dartId;
     } else {
       // Not the first time we see an element with this name. Append a number
       // to make it unique.
       String id;
       do {
         usedCount++;
         id = '$dartId$usedCount';
       } while (usedGlobals[id] !== null);
       usedGlobals[dartId] = usedCount;
       globals[element] = id;
       return id;
-    }    
+    }
   }
 
   String isolateAccess(Element element) {
     String jsId = globals[element];
     if (jsId === null) jsId = define(element);
     return "$currentIsolate.$jsId"; 
   }
 
   String isolatePropertyAccess(Element element) {
     String jsId = globals[element];
     if (jsId === null) jsId = define(element);
     return "$isolate.prototype.$jsId";     
   }
 
-  String methodName(Element element) {
+  String instanceName(Element element) {
+    if (element is ConstructorBodyElement) {

[ngeoffray, 2011/12/08 16:01:40]

element.kind == ElementKind.CONSTRUCTOR_BODY

[floitsch, 2011/12/08 16:36:00]

Done.

+      return constructorBodyName(element);
+    }
     // TODO(floitsch): mangle if necessary.
     return '${element.name}';
   }
+
+  String constructorBodyName(Element element) {

[ngeoffray, 2011/12/08 16:01:40]

assert(element.kind == ElementKind.BODY_CONSTRUCTOR)?

[floitsch, 2011/12/08 16:36:00]

Actually it must be a constructor. This is necessary, as we need to get to the
body-constructor from a constructor when we call 'super'.
Added comment and assert.

+    // TODO(floitsch): mangle if necessary. Make sure it doesn't collide with
+    // normal methods.
+    String candidate = '${element.name}';
+    if (candidate == '') candidate = 'default';
+    return candidate;
+  }
 }