Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8872009: Revert 113568 - extensions: remove install/uninstall terminology (Closed)

Created:
9 years ago by Dan Beam
Modified:
9 years ago
Reviewers:
Evan Stade
CC:
chromium-reviews, jstritar+watch_chromium.org, jennb, prasadt, Dmitry Titov, dcheng, mihaip+watch_chromium.org, Aaron Boodman, jianli, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr., estade+watch_chromium.org
Visibility:
Public.

Description

Revert 113568 - extensions: remove install/uninstall terminology replace with add/remove BUG=102610 TEST=manual (for those strings I actually know how to trigger) Review URL: http://codereview.chromium.org/8835003 TBR=estade@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113569

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -78 lines) Patch
M chrome/app/generated_resources.grd View 17 chunks +28 lines, -24 lines 0 comments Download
M chrome/browser/download/download_item_model.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_context_menu_model.cc View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/extensions/extension_global_error.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_install_ui.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_install_ui.cc View 3 chunks +4 lines, -9 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_action_context_menu.mm View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_installed_bubble_bridge.mm View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/extensions/extension_installed_bubble_gtk.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/ui/panels/panel_settings_menu_model.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_install_dialog_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_installed_bubble.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_resource_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/permission_warnings.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/static/permission_warnings.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/management/test/basics.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Dan Beam
9 years ago (2011-12-08 06:43:01 UTC) #1
Evan Stade
9 years ago (2011-12-08 17:56:38 UTC) #2 
would have been better just to leave the tree open and fix the issue. Aura
probably breaks frequently since it's not a default try bot and apparently
doesn't get run by the CQ either.

Powered by Google App Engine
This is Rietveld 408576698