Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1503)

Unified Diff: chrome/browser/extensions/extension_install_ui.cc

Issue 8872009: Revert 113568 - extensions: remove install/uninstall terminology (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_install_ui.cc
===================================================================
--- chrome/browser/extensions/extension_install_ui.cc (revision 113568)
+++ chrome/browser/extensions/extension_install_ui.cc (working copy)
@@ -42,7 +42,7 @@
#include "ui/base/resource/resource_bundle.h"
static const int kTitleIds[ExtensionInstallUI::NUM_PROMPT_TYPES] = {
- 0,
+ IDS_EXTENSION_INSTALL_PROMPT_TITLE,
IDS_EXTENSION_INLINE_INSTALL_PROMPT_TITLE,
IDS_EXTENSION_RE_ENABLE_PROMPT_TITLE,
IDS_EXTENSION_PERMISSIONS_PROMPT_TITLE
@@ -55,7 +55,7 @@
};
static const int kAcceptButtonIds[ExtensionInstallUI::NUM_PROMPT_TYPES] = {
IDS_EXTENSION_PROMPT_INSTALL_BUTTON,
- IDS_EXTENSION_PROMPT_INSTALL_BUTTON,
+ IDS_EXTENSION_PROMPT_INLINE_INSTALL_BUTTON,
IDS_EXTENSION_PROMPT_RE_ENABLE_BUTTON,
IDS_EXTENSION_PROMPT_PERMISSIONS_BUTTON
};
@@ -103,13 +103,8 @@
rating_count_ = rating_count;
}
-string16 ExtensionInstallUI::Prompt::GetDialogTitle(
- const Extension* extension) const {
- if (type_ == INSTALL_PROMPT) {
- return l10n_util::GetStringUTF16(extension->is_app() ?
- IDS_EXTENSION_INSTALL_APP_PROMPT_TITLE :
- IDS_EXTENSION_INSTALL_EXTENSION_PROMPT_TITLE);
- } else if (type_ == INLINE_INSTALL_PROMPT) {
+string16 ExtensionInstallUI::Prompt::GetDialogTitle() const {
+ if (type_ == INLINE_INSTALL_PROMPT) {
return l10n_util::GetStringFUTF16(
kTitleIds[type_], l10n_util::GetStringUTF16(IDS_SHORT_PRODUCT_NAME));
} else {
« no previous file with comments | « chrome/browser/extensions/extension_install_ui.h ('k') | chrome/browser/ui/cocoa/extensions/extension_action_context_menu.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698