extensions: remove install/uninstall terminology

extensions: remove install/uninstall terminology

replace with add/remove

BUG=102610
TEST=manual (for those strings I actually know how to trigger)


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113568

[Evan Stade, 2011-12-07 04:19:16]

these strings are all vetted by Bryan

aaron: extensions
andybons: cocoa
sky: the rest

[Evan Stade, 2011-12-07 04:20:27]

On 2011/12/07 04:19:16, Evan Stade wrote:
> these strings are all vetted by Bryan

Brian even

> 
> aaron: extensions
> andybons: cocoa
> sky: the rest

[Mihai Parparita -not on Chrome, 2011-12-07 04:41:12]

http://codereview.chromium.org/8835003/diff/4001/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/8835003/diff/4001/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:4327: <message
name="IDS_EXTENSION_PROMPT_INLINE_INSTALL_BUTTON" desc="Text for the inline
install button on the extension install prompt">
You can now remove this message and replace references to it with
IDS_EXTENSION_PROMPT_INSTALL_BUTTON.

http://codereview.chromium.org/8835003/diff/4001/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_install_ui.cc (right):

http://codereview.chromium.org/8835003/diff/4001/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_install_ui.cc:46:
IDS_EXTENSION_INLINE_INSTALL_PROMPT_TITLE,
If regular installation won't have a title, then inline installs should be the
same (the general intention is to have inline installation be as close to
regular installation as possible).

[sky, 2011-12-07 04:54:08]

LGTM

[Evan Stade, 2011-12-07 05:54:23]

http://codereview.chromium.org/8835003/diff/4001/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/8835003/diff/4001/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:4327: <message
name="IDS_EXTENSION_PROMPT_INLINE_INSTALL_BUTTON" desc="Text for the inline
install button on the extension install prompt">
On 2011/12/07 04:41:12, Mihai Parparita wrote:
> You can now remove this message and replace references to it with
> IDS_EXTENSION_PROMPT_INSTALL_BUTTON.

to what benefit? If you look at the code, I think it actually makes it a little
more confusing if you do that. Identical grit strings are coalesced before
translation, so this doesn't even create extra work for translators.

http://codereview.chromium.org/8835003/diff/4001/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_install_ui.cc (right):

http://codereview.chromium.org/8835003/diff/4001/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_install_ui.cc:46:
IDS_EXTENSION_INLINE_INSTALL_PROMPT_TITLE,
On 2011/12/07 04:41:12, Mihai Parparita wrote:
> If regular installation won't have a title, then inline installs should be the
> same (the general intention is to have inline installation be as close to
> regular installation as possible).

regular installs will have a title. See below.

[Evan Stade, 2011-12-07 06:00:37]

http://codereview.chromium.org/8835003/diff/4001/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/8835003/diff/4001/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:4327: <message
name="IDS_EXTENSION_PROMPT_INLINE_INSTALL_BUTTON" desc="Text for the inline
install button on the extension install prompt">
On 2011/12/07 05:54:23, Evan Stade wrote:
> On 2011/12/07 04:41:12, Mihai Parparita wrote:
> > You can now remove this message and replace references to it with
> > IDS_EXTENSION_PROMPT_INSTALL_BUTTON.
> 
> to what benefit? If you look at the code, I think it actually makes it a
little
> more confusing if you do that. Identical grit strings are coalesced before
> translation, so this doesn't even create extra work for translators.

OK, I take it back. I see that some other aspects of the inline install prompt
just use the normal strings and this one should follow suit.

[Andrew Bonventre, 2011-12-07 13:37:22]

lgtm

[Mihai Parparita -not on Chrome, 2011-12-07 17:39:25]

LGTM

[Aaron Boodman, 2011-12-07 22:45:10]

lgtm w/ minor question

http://codereview.chromium.org/8835003/diff/19/chrome/app/generated_resources...
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/8835003/diff/19/chrome/app/generated_resources...
chrome/app/generated_resources.grd:4248: Remove from <ph
name="SHORT_PRODUCT_NAME">$1<ex>Chrome</ex></ph>
Where does this show up? It seems like in some contexts it might be too long,
and Remove should be used instead.

[Evan Stade, 2011-12-07 23:16:55]

http://codereview.chromium.org/8835003/diff/19/chrome/app/generated_resources...
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/8835003/diff/19/chrome/app/generated_resources...
chrome/app/generated_resources.grd:4248: Remove from <ph
name="SHORT_PRODUCT_NAME">$1<ex>Chrome</ex></ph>
On 2011/12/07 22:45:10, Aaron Boodman wrote:
> Where does this show up? It seems like in some contexts it might be too long,
> and Remove should be used instead.

in the context menu for extension actions, apparently. Plenty of room there.
However, it also means the string needs different sentence/title casing for
different platforms (same goes for the rest of the extension action context menu
items). I'll file a bug.

[commit-bot: I haz the power, 2011-12-08 05:08:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/8835003/13001

[commit-bot: I haz the power, 2011-12-08 06:16:29]

Change committed as 113568