Merge BorderContentsView into BubbleFrameView; simplify.

Merge BorderContentsView into BubbleFrameView; simplify.

Merge these redundant classes and their unit tests.
Do not try_mirroring_arrow with dummy anchor rects.
Deprecate unused allow_bubble_offscreen bubble flag.
Replace GetArrowLocation virtual with simple setter/getter pair.
Return anchor view bounds in BubbleDelegateView::GetAnchorRect.
Other refactoring and simplification.

BUG=106050
TEST=Bubbles are anchored correctly with their arrows in the right location.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114598

[msw, 2011-12-14 10:16:14]

Hey Alice, please take a look; thanks!

[alicet1, 2011-12-14 21:48:53]

looks ok in general, thanks for the clean up, and one question below.

also, it wasn't clear to me if I want to allow my bubble offscreen, how would I
do that from the delegate?

thanx,
alice

http://codereview.chromium.org/8870003/diff/12020/ui/views/bubble/bubble_fram...
File ui/views/bubble/bubble_frame_view.cc (right):

http://codereview.chromium.org/8870003/diff/12020/ui/views/bubble/bubble_fram...
ui/views/bubble/bubble_frame_view.cc:72: gfx::Rect(), client_bounds.size(),
false);
why do this one and the one on line 81 try_mirroring_arrow=false?

[msw, 2011-12-14 22:31:09]

>if I want to allow my bubble offscreen, how would I
do that from the delegate?

There were no bubbles that were being allowed offscreen.
It seems okay to drop support when there is no use case.
Adding support (if needed later) would be very simple.

http://codereview.chromium.org/8870003/diff/12020/ui/views/bubble/bubble_fram...
File ui/views/bubble/bubble_frame_view.cc (right):

http://codereview.chromium.org/8870003/diff/12020/ui/views/bubble/bubble_fram...
ui/views/bubble/bubble_frame_view.cc:72: gfx::Rect(), client_bounds.size(),
false);
On 2011/12/14 21:48:54, alicet1 wrote:
> why do this one and the one on line 81 try_mirroring_arrow=false?

Because they are using dummy anchor rect values |gfx::Rect()|, which shouldn't
affect the arrow location.

[msw, 2011-12-15 00:51:03]

+Sky for OWNERS. PTAL; thanks!

[sky, 2011-12-15 01:20:47]

LGTM

[commit-bot: I haz the power, 2011-12-15 03:21:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/8870003/29001

[commit-bot: I haz the power, 2011-12-15 05:08:28]

Change committed as 114598