Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(765)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: scripts/master/try_job_base_bb7.py

Issue 8847005: Add decorations to bot names for modifying parts of try sets. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build/
Patch Set: '' Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« scripts/master/try_job_base.py ('K') | « scripts/master/try_job_base.py ('k') | scripts/master/try_job_base_bb8.py » ('j') | scripts/master/try_job_base_bb8.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/master/try_job_base_bb7.py
===================================================================
--- scripts/master/try_job_base_bb7.py (revision 113846)
+++ scripts/master/try_job_base_bb7.py (working copy)
@@ -12,6 +12,7 @@
from twisted.web import http
from master.try_job_stamp import TryJobStamp
+import master.try_job_decoration as decor
class TryJobBaseMixIn:
@@ -106,11 +107,12 @@
assert isinstance(builder_names, list)
for builder_name in builder_names:
build_set = buildset.BuildSet(
- [builder_name],
+ builder_name.split(':')[0:1],
M-A Ruel 2011/12/09 21:50:29 builder_name.split(':', 1)[0:1],
Peter Mayo 2011/12/10 01:08:27 Done.
jobstamp,
reason=reason,
bsid=buildset_id,
- properties=props)
+ properties=decor.parse_decoration(props,
+ ':'.join(builder_name.split(':')[1:])))
M-A Ruel 2011/12/09 21:50:29 ''.join(builder_name.split(':', 1)[1:])
Peter Mayo 2011/12/10 01:08:27 Done.
build_sets.append(build_set)
self.CancelJobsMatching(build_set, builder_name)
for build_set in build_sets:
« scripts/master/try_job_base.py ('K') | « scripts/master/try_job_base.py ('k') | scripts/master/try_job_base_bb8.py » ('j') | scripts/master/try_job_base_bb8.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698