Chromium Code Reviews| Index: scripts/master/try_job_base_bb8.py |
| =================================================================== |
| --- scripts/master/try_job_base_bb8.py (revision 113846) |
| +++ scripts/master/try_job_base_bb8.py (working copy) |
| @@ -9,6 +9,7 @@ |
| from buildbot.schedulers.trysched import BadJobfile # pylint: disable=W0611 |
| from twisted.internet import defer |
| +import master.try_job_decoration as decor |
| class TryJobBaseMixIn: |
| _last_lkgr = None |
| @@ -31,12 +32,18 @@ |
| repository=parsed_job['repository'] or '', |
| changeids=changeids) |
| def create_buildset(ssid): |
| - log.msg('Creating try job %s' % ssid) |
| - return self.addBuildsetForSourceStamp(ssid=ssid, |
| - reason=parsed_job['name'], |
| - external_idstring=parsed_job['name'], |
| - builderNames=parsed_job['bot'], |
| - properties=self.get_props(parsed_job)) |
| + log.msg('Creating try job(s) %s' % ssid) |
| + result = None |
| + for build in parsed_job['bot']: |
|
M-A Ruel
2011/12/09 21:50:29
builder
build is confusing.
Peter Mayo
2011/12/10 01:08:27
Same as other instance.
|
| + bot = build.split(':')[0] |
|
M-A Ruel
2011/12/09 21:50:29
bot = build.split(':', 1)[0]
Peter Mayo
2011/12/10 01:08:27
Done.
|
| + result = self.addBuildsetForSourceStamp(ssid=ssid, |
| + reason=parsed_job['name'], |
| + external_idstring=parsed_job['name'], |
| + builderNames=[bot], |
| + properties=decor.parse_decoration(self.get_props(parsed_job), |
| + ':'.join(build.split(':')[1:]))) |
|
M-A Ruel
2011/12/09 21:50:29
''.join(build.split(':', 1)[1:])
will work even if
Peter Mayo
2011/12/10 01:08:27
FWIW, so does the existing syntax, by experiment a
|
| + |
| + return result |
| d.addCallback(create_buildset) |
| d.addErrback(log.err, "Failed to queue a try job!") |
| return d |