Chromium Code Reviews| Index: scripts/master/try_job_base.py |
| =================================================================== |
| --- scripts/master/try_job_base.py (revision 113846) |
| +++ scripts/master/try_job_base.py (working copy) |
| @@ -72,12 +72,13 @@ |
| try_int('patchset') |
| try_int('issue') |
| - builder_names = [] |
| + build_names = [] |
|
M-A Ruel
2011/12/09 21:50:29
Why build_names? It's confusing. It's not the name
Peter Mayo
2011/12/10 01:08:27
But it's not always the name of a builder. win is
M-A Ruel
2011/12/12 20:46:58
Personally, I wouldn't touch this file at all in t
|
| if 'bot' in options: |
| - builder_names = options.get('bot', '').split(',') |
| - options['bot'] = self.pools.Select(builder_names, options['project']) |
| + build_names = options.get('bot', '').split(',') |
| + options['bot'] = self.pools.Select(build_names, options['project']) |
| + bot_names = [b.split(':')[0] for b in options['bot']] |
|
M-A Ruel
2011/12/09 21:50:29
I'd keep the log intact, it's more informative.
Peter Mayo
2011/12/10 01:08:27
Interesting, then chose is often the wrong verb.
|
| log.msg( |
| - 'Choose %s for job %s' % (','.join(options['bot']), options['reason'])) |
| + 'Chose %s for job %s' % (','.join(bot_names), options['reason'])) |
| return options |
| def get_props(self, options): |