Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(877)

Unified Diff: scripts/master/try_job_base.py

Issue 8847005: Add decorations to bot names for modifying parts of try sets. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build/
Patch Set: '' Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/master/try_job_base_bb7.py » ('j') | scripts/master/try_job_base_bb7.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/master/try_job_base.py
===================================================================
--- scripts/master/try_job_base.py (revision 113846)
+++ scripts/master/try_job_base.py (working copy)
@@ -72,12 +72,13 @@
try_int('patchset')
try_int('issue')
- builder_names = []
+ build_names = []
M-A Ruel 2011/12/09 21:50:29 Why build_names? It's confusing. It's not the name
Peter Mayo 2011/12/10 01:08:27 But it's not always the name of a builder. win is
M-A Ruel 2011/12/12 20:46:58 Personally, I wouldn't touch this file at all in t
if 'bot' in options:
- builder_names = options.get('bot', '').split(',')
- options['bot'] = self.pools.Select(builder_names, options['project'])
+ build_names = options.get('bot', '').split(',')
+ options['bot'] = self.pools.Select(build_names, options['project'])
+ bot_names = [b.split(':')[0] for b in options['bot']]
M-A Ruel 2011/12/09 21:50:29 I'd keep the log intact, it's more informative.
Peter Mayo 2011/12/10 01:08:27 Interesting, then chose is often the wrong verb.
log.msg(
- 'Choose %s for job %s' % (','.join(options['bot']), options['reason']))
+ 'Chose %s for job %s' % (','.join(bot_names), options['reason']))
return options
def get_props(self, options):
« no previous file with comments | « no previous file | scripts/master/try_job_base_bb7.py » ('j') | scripts/master/try_job_base_bb7.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698