Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: chrome/chrome_dll.gypi

Issue 8824003: Breakpad: Compile Breakpad into Chromium by default on Mac (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Split out mac_breakpad_symbols too Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/chrome_dll.gypi
diff --git a/chrome/chrome_dll.gypi b/chrome/chrome_dll.gypi
index 8ed2a5c16adbe6d85574194a1574899fedcb8b98..7625e4cbc6c2ea2160bac15aac793754585974dc 100644
--- a/chrome/chrome_dll.gypi
+++ b/chrome/chrome_dll.gypi
@@ -366,7 +366,8 @@
# but this seems like a really good place to store them.
'postbuild_name': 'Tweak Info.plist',
'action': ['<(tweak_info_plist_path)',
- '-b<(mac_breakpad)',
+ '--breakpad=<(mac_breakpad)',
+ '--breakpad_uploads=<(mac_breakpad_uploads)',
'-k0',
'-s1',
'<(branding)',
@@ -457,11 +458,13 @@
},
],
}],
- ['mac_breakpad==1', {
+ ['mac_breakpad_symbols==1', {
'variables': {
# A real .dSYM is needed for dump_syms to operate on.
'mac_real_dsym': 1,
},
+ }],
+ ['mac_breakpad==1', {
'sources': [
'app/breakpad_mac.mm',
'app/breakpad_mac.h',

Powered by Google App Engine
This is Rietveld 408576698