Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: chrome/chrome_exe.gypi

Issue 8824003: Breakpad: Compile Breakpad into Chromium by default on Mac (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Split out mac_breakpad_symbols too Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/chrome_exe.gypi
diff --git a/chrome/chrome_exe.gypi b/chrome/chrome_exe.gypi
index e19d4eae883889def38a05f3ed51d66cfb44fb20..27692039f6f710c55e2836293b054a403d72d1ee 100644
--- a/chrome/chrome_exe.gypi
+++ b/chrome/chrome_exe.gypi
@@ -166,7 +166,7 @@
'browser/ui/cocoa/applescript/scripting.sdef',
],
}],
- ['mac_breakpad==1', {
+ ['mac_breakpad_symbols==1', {
'variables': {
# A real .dSYM is needed for dump_syms to operate on.
'mac_real_dsym': 1,
@@ -213,7 +213,7 @@
],
}],
],
- }], # mac_breakpad
+ }], # mac_breakpad_symbols
],
'product_name': '<(mac_product_name)',
'xcode_settings': {
@@ -301,17 +301,18 @@
{
# Modify the Info.plist as needed. The script explains why this
# is needed. This is also done in the helper_app and chrome_dll
- # targets. Use -b0 to not include any Breakpad information; that
- # all goes into the framework's Info.plist. Keystone information
- # is included if Keystone is enabled. The application reads
- # Keystone keys from this plist and not the framework's, and
- # the ticket will reference this Info.plist to determine the tag
- # of the installed product. Use -s1 to include Subversion
- # information. The -p flag controls whether to insert PDF as a
- # supported type identifier that can be opened.
+ # targets. Use --breakpad=0 to not include any Breakpad
+ # information; that all goes into the framework's Info.plist.
+ # Keystone information is included if Keystone is enabled. The
+ # application reads Keystone keys from this plist and not the
+ # framework's, and the ticket will reference this Info.plist to
+ # determine the tag of the installed product. Use -s1 to
+ # include Subversion information. The -p flag controls whether
+ # to insert PDF as a supported type identifier that can be
+ # opened.
'postbuild_name': 'Tweak Info.plist',
'action': ['<(tweak_info_plist_path)',
- '-b0',
+ '--breakpad=0',
'-k<(mac_keystone)',
'-s1',
'-p<(internal_pdf)',

Powered by Google App Engine
This is Rietveld 408576698