Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4515)

Unified Diff: chrome/chrome.gyp

Issue 8824003: Breakpad: Compile Breakpad into Chromium by default on Mac (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Split out mac_breakpad_symbols too Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/chrome.gyp
diff --git a/chrome/chrome.gyp b/chrome/chrome.gyp
index 40c7ed7219785da671cecd5b4c9e2f611d0c4ab9..5d5e4791a6d3c5c14fad74791c14cf8d5b149b60 100644
--- a/chrome/chrome.gyp
+++ b/chrome/chrome.gyp
@@ -775,12 +775,12 @@
{
# Modify the Info.plist as needed. The script explains why this
# is needed. This is also done in the chrome and chrome_dll
- # targets. In this case, -b0, -k0, and -s0 are used because
- # Breakpad, Keystone, and Subersion keys are never placed into
- # the helper.
+ # targets. In this case, --breakpad=0, -k0, and -s0 are used
+ # because Breakpad, Keystone, and Subersion keys are never
+ # placed into the helper.
'postbuild_name': 'Tweak Info.plist',
'action': ['<(tweak_info_plist_path)',
- '-b0',
+ '--breakpad=0',
'-k0',
'-s0',
'<(branding)',
@@ -796,7 +796,7 @@
},
],
'conditions': [
- ['mac_breakpad==1', {
+ ['mac_breakpad_symbols==1', {
'variables': {
# A real .dSYM is needed for dump_syms to operate on.
'mac_real_dsym': 1,

Powered by Google App Engine
This is Rietveld 408576698