Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 8822005: Fix buffer overflow in _canonicalize. (Closed)

Created:
9 years ago by falken
Modified:
9 years ago
Reviewers:
jungshik at Google
CC:
inferno
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -2 lines) Patch
M README.chromium View 1 1 chunk +4 lines, -0 lines 0 comments Download
A patches/canonicalize.patch View 1 1 chunk +22 lines, -0 lines 0 comments Download
M source/common/uloc.c View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
falken
http://codereview.chromium.org/8822005/diff/1/source/common/uloc.c File source/common/uloc.c (right): http://codereview.chromium.org/8822005/diff/1/source/common/uloc.c#newcode1808 source/common/uloc.c:1808: if (len > 0 && len <= nameCapacity && ...
9 years ago (2011-12-06 08:13:29 UTC) #1
jungshik at Google
Hmm... I thought I had taken the upstream fix for this already, but apparently not. ...
9 years ago (2011-12-06 20:04:31 UTC) #2
jungshik at Google
Sorry this is a different issue. Can you file an upstream bug at http://bugs.icu-project.org/trac and ...
9 years ago (2011-12-06 21:57:57 UTC) #3
falken
On 2011/12/06 21:57:57, Jungshik Shin wrote: > Sorry this is a different issue. > > ...
9 years ago (2011-12-07 02:53:11 UTC) #4
jungshik at Google
Thanks. LGTM. Can you just add the upstream bug reference to the CL description as ...
9 years ago (2011-12-07 20:26:38 UTC) #5
dxr
9 years ago (2011-12-09 23:12:21 UTC) #6

Powered by Google App Engine
This is Rietveld 408576698