source/common/uloc.c - Issue 8822005: Fix buffer overflow in _canonicalize.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: source/common/uloc.c

Issue 8822005: Fix buffer overflow in _canonicalize. (Closed) Base URL: svn://chrome-svn/chrome/trunk/deps/third_party/icu46/

Patch Set: '' Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: source/common/uloc.c

===================================================================

--- source/common/uloc.c (revision 113138)

+++ source/common/uloc.c (working copy)

@@ -1797,7 +1797,7 @@

int32_t variantLen = _deleteVariant(variant, uprv_min(variantSize, (nameCapacity-len)), variantToCompare, n);

len -= variantLen;

if (variantLen > 0) {

- if (name[len-1] == '_') { /* delete trailing '_' */

+ if (len > 0 && name[len-1] == '_') { /* delete trailing '_' */

--len;

}

addKeyword = VARIANT_MAP[j].keyword;

@@ -1805,7 +1805,7 @@

break;

}

- if (name[len-1] == '_') { /* delete trailing '_' */

+ if (len > 0 && len <= nameCapacity && name[len-1] == '_') { /* delete trailing '_' */

--len;

}

« no previous file with comments | « patches/canonicalize.patch ('k') | no next file » | no next file with comments »