patches/canonicalize.patch - Issue 8822005: Fix buffer overflow in _canonicalize.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: patches/canonicalize.patch

Issue 8822005: Fix buffer overflow in _canonicalize. (Closed) Base URL: svn://chrome-svn/chrome/trunk/deps/third_party/icu46/

Patch Set: '' Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 Index: source/common/uloc.c

	2 ===================================================================

	3 --- source/common/uloc.c (revision 113138)

	4 +++ source/common/uloc.c (working copy)

	5 @@ -1797,7 +1797,7 @@

	6 int32_t variantLen = _deleteVariant(variant, uprv_min(variantSi ze, (nameCapacity-len)), variantToCompare, n);

	7 len -= variantLen;

	8 if (variantLen > 0) {

	9 - if (name[len-1] == '_') { /* delete trailing '_' */

	10 + if (len > 0 && name[len-1] == '_') { /* delete trailing '_' */

	11 --len;

	12 }

	13 addKeyword = VARIANT_MAP[j].keyword;

	14 @@ -1805,7 +1805,7 @@

	15 break;

	16 }

	17 }

	18 - if (name[len-1] == '_') { /* delete trailing '_' */

	19 + if (len > 0 && len <= nameCapacity && name[len-1] == '_') { /* dele te trailing '_' */

	20 --len;

	21 }

	22 }

OLD	NEW

« no previous file with comments | « README.chromium ('k') | source/common/uloc.c » ('j') | no next file with comments »