Fix leak; remove "explicit" keyword from multi-argument constructor.

Fix leak; remove "explicit" keyword from multi-argument constructor.

BUG=106529
TEST=removed suppressions from mem/heap check tools


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113293

[cbentzel, 2011-12-06 18:56:32]

http://codereview.chromium.org/8819029/diff/1/chrome/browser/extensions/api/s...
File chrome/browser/extensions/api/socket/socket_api_controller.cc (right):

http://codereview.chromium.org/8819029/diff/1/chrome/browser/extensions/api/s...
chrome/browser/extensions/api/socket/socket_api_controller.cc:67: delete
udp_client_socket_;
Could you use a scoped_ptr instead?

[miket_OOO, 2011-12-06 19:09:54]

> Could you use a scoped_ptr instead?

Only if you can tell me why I didn't do that in the first place! (shame)

[miket_OOO, 2011-12-06 19:12:35]

I have recovered from my temporary insanity. scoped_ptr added, changes uploaded.
Please re-review.

[asargent_no_longer_on_chrome, 2011-12-06 19:15:42]

lgtm

[cbentzel, 2011-12-06 19:15:45]

LGTM

[commit-bot: I haz the power, 2011-12-06 21:14:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/miket@chromium.org/8819029/4001

[commit-bot: I haz the power, 2011-12-06 21:59:32]

Try job failure for 8819029-4001 (retry) on linux_clang for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

[commit-bot: I haz the power, 2011-12-06 22:03:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/miket@chromium.org/8819029/4001

[commit-bot: I haz the power, 2011-12-06 23:45:23]

Change committed as 113293