Fix leak; remove "explicit" keyword from multi-argument constructor.

chrome/browser/extensions/api/socket/socket_api_controller.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/json/json_writer.h"
 #include "base/stl_util.h"
 #include "base/values.h"
 #include "chrome/browser/extensions/api/socket/socket_api_controller.h"
 #include "chrome/browser/profiles/profile.h"
 #include "net/base/io_buffer.h"
 #include "net/base/net_errors.h"
 #include "net/base/rand_callback.h"
 #include "net/udp/datagram_socket.h"
 #include "net/udp/udp_client_socket.h"
 #include "net/udp/udp_socket.h"
 
 using namespace net;
 
 namespace extensions {
 
 // A Socket wraps a low-level socket and includes housekeeping information that
 // we need to manage it in the context of an extension.
 class Socket {
  public:
-  explicit Socket(const Profile* profile, const std::string& src_extension_id,
-                  const GURL& src_url);
+  Socket(const Profile* profile, const std::string& src_extension_id,
+         const GURL& src_url);
   ~Socket();
 
   bool Connect(const net::IPEndPoint& ip_end_point);
   void Close();
   int Write(const std::string message);
 
  private:
   // TODO(miket): this metadata will enable us to pass events back to the
   // extension that created this Socket.
   const Profile* profile_;
@@ skipping 20 matching lines @@
           NULL,
           NetLog::Source())),
       is_connected_(false),
       ALLOW_THIS_IN_INITIALIZER_LIST(
           io_callback_(this, &Socket::OnIOComplete)) {}
 
 Socket::~Socket() {
   if (is_connected_) {
     Close();
   }
+  delete udp_client_socket_;

[cbentzel, 2011/12/06 18:56:32]

Could you use a scoped_ptr instead?

 }
 
 void Socket::OnIOComplete(int result) {
   // We don't need to do anything.
 }
 
 bool Socket::Connect(const net::IPEndPoint& ip_end_point) {
   is_connected_ = udp_client_socket_->Connect(ip_end_point) == net::OK;
   return is_connected_;
 }
@@ skipping 95 matching lines @@
 
 int SocketController::WriteUdp(int socket_id, const std::string message) {
   Socket* socket = GetSocket(socket_id);
   if (!socket) {
     return -1;
   }
   return socket->Write(message);
 }
 
 }  // namespace extensions