Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3589)

Unified Diff: chrome/browser/extensions/api/socket/socket_api_controller.cc

Issue 8819029: Fix leak; remove "explicit" keyword from multi-argument constructor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Use scoped_ptr, silly! Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/heapcheck/suppressions.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/socket/socket_api_controller.cc
diff --git a/chrome/browser/extensions/api/socket/socket_api_controller.cc b/chrome/browser/extensions/api/socket/socket_api_controller.cc
index 21952973ef560f3f3809fcf7a86e1cbf79b163db..30890b85acca10a41ecb4c7a5c934fda633932e7 100644
--- a/chrome/browser/extensions/api/socket/socket_api_controller.cc
+++ b/chrome/browser/extensions/api/socket/socket_api_controller.cc
@@ -22,8 +22,8 @@ namespace extensions {
// we need to manage it in the context of an extension.
class Socket {
public:
- explicit Socket(const Profile* profile, const std::string& src_extension_id,
- const GURL& src_url);
+ Socket(const Profile* profile, const std::string& src_extension_id,
+ const GURL& src_url);
~Socket();
bool Connect(const net::IPEndPoint& ip_end_point);
@@ -38,7 +38,7 @@ class Socket {
std::string src_extension_id_;
GURL src_url_;
- net::UDPClientSocket* udp_client_socket_;
+ scoped_ptr<net::UDPClientSocket> udp_client_socket_;
bool is_connected_;
net::OldCompletionCallbackImpl<Socket> io_callback_;
« no previous file with comments | « no previous file | tools/heapcheck/suppressions.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698