Add aura compile testing by default to likely areas.

Add aura compile testing by default to likely areas (1).

TBR=God
NOTRY=true
BUG=chromium:107599
TEST=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114490

[Emmanuel Saint-loubert-Bié, 2011-12-06 17:01:28]

The folders selected look good to me! However I do not know python so someone
else should provide a more definitive LGTM.

[oshima, 2011-12-06 18:15:18]

http://codereview.chromium.org/8818013/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

http://codereview.chromium.org/8818013/diff/1/PRESUBMIT.py#newcode343
PRESUBMIT.py:343: if any(re.search(aura_re,f.LocalPath()) for f in
change.AffectedFiles()):
space after ","

http://codereview.chromium.org/8818013/diff/1/PRESUBMIT.py#newcode344
PRESUBMIT.py:344: preferred.append('linux_aura_compile')
If we can affort only compilation test, is it possible to use clang and do
component build?

[Peter Mayo, 2011-12-09 21:45:28]

blocked on http://codereview.chromium.org/8847005/

This avoids duplicating the builder definition to define the 'other' way of
compiling.

http://codereview.chromium.org/8818013/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

http://codereview.chromium.org/8818013/diff/1/PRESUBMIT.py#newcode343
PRESUBMIT.py:343: if any(re.search(aura_re,f.LocalPath()) for f in
change.AffectedFiles()):
On 2011/12/06 18:15:19, oshima wrote:
> space after ","

Done.

http://codereview.chromium.org/8818013/diff/1/PRESUBMIT.py#newcode344
PRESUBMIT.py:344: preferred.append('linux_aura_compile')
On 2011/12/06 18:15:19, oshima wrote:
> If we can affort only compilation test, is it possible to use clang and do
> component build?

Perhaps one day, but not as a first step given some of the issues we've had with
it recently.

[M-A Ruel, 2011-12-09 21:51:40]

+thakis since one of you will have to merge.

lgtm

http://codereview.chromium.org/8818013/diff/2001/PRESUBMIT.py
File PRESUBMIT.py (right):

http://codereview.chromium.org/8818013/diff/2001/PRESUBMIT.py#newcode341
PRESUBMIT.py:341: preferred = ['win', 'linux', 'mac']
Note that it'll conflict with a CL from thakis where he changes these to _rel.

[oshima, 2011-12-09 21:52:54]

http://codereview.chromium.org/8818013/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

http://codereview.chromium.org/8818013/diff/1/PRESUBMIT.py#newcode344
PRESUBMIT.py:344: preferred.append('linux_aura_compile')
On 2011/12/09 21:45:29, Peter Mayo wrote:
> On 2011/12/06 18:15:19, oshima wrote:
> > If we can affort only compilation test, is it possible to use clang and do
> > component build?
> 
> Perhaps one day, but not as a first step given some of the issues we've had
with
> it recently.

If it's not straightforward, then nvm. LGTM

[Nico, 2011-12-09 21:58:11]

Is linux_aura on goma yet?

[Peter Mayo (wrong one), 2011-12-09 21:59:47]

I cloned the state of linux at the time,

On Fri, Dec 9, 2011 at 4:58 PM, <thakis@chromium.org> wrote:

> Is linux_aura on goma yet?
>
>
http://codereview.chromium.**org/8818013/<http://codereview.chromium.org/8818...
>



-- 

Peter Mayo | Waterloo | petermayo@google.com | 519-880-3439

[Nico, 2011-12-09 22:01:46]

On Fri, Dec 9, 2011 at 1:59 PM, Peter Mayo <petermayo@google.com> wrote:

> I cloned the state of linux at the time,


Did linux at the time use goma then? :-P

[Peter Mayo, 2011-12-14 06:01:12]

On 2011/12/09 22:01:46, Nico wrote:
> On Fri, Dec 9, 2011 at 1:59 PM, Peter Mayo <mailto:petermayo@google.com>
wrote:
> 
> > I cloned the state of linux at the time,
> 
> 
> Did linux at the time use goma then? :-P

More to the point, it does now.

[Peter Mayo, 2011-12-14 06:02:19]

I am going to split this CL up so that we can trickle in these changes so we
don't overflow the infrastructure.

[Peter Mayo, 2011-12-14 20:41:02]

Step 1

[commit-bot: I haz the power, 2011-12-14 20:41:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/petermayo@chromium.org/8818013/9001

[commit-bot: I haz the power, 2011-12-14 20:41:27]

Presubmit check for 8818013-9001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
ui/aura/PRESUBMIT.py,ui/aura_shell/PRESUBMIT.py,ui/resources/aura/PRESUBMIT.py

[commit-bot: I haz the power, 2011-12-14 20:49:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/petermayo@chromium.org/8818013/9001

[commit-bot: I haz the power, 2011-12-14 20:49:50]

Change committed as 114490

[M-A Ruel, 2012-02-06 20:23:05]

http://codereview.chromium.org/8818013/diff/9001/PRESUBMIT.py
File PRESUBMIT.py (right):

http://codereview.chromium.org/8818013/diff/9001/PRESUBMIT.py#newcode12
PRESUBMIT.py:12: import re
FTR, I would have preferred this import to be function local.