Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 8818013: Add aura compile testing by default to likely areas. (Closed)

Created:
9 years ago by Peter Mayo
Modified:
8 years, 10 months ago
CC:
chromium-reviews, jstritar+watch_chromium.org, sadrul, jonathan.backer, Ian Vollick, dhollowa+watch_chromium.org, ben+watch_chromium.org, mihaip+watch_chromium.org, Aaron Boodman, piman+watch_chromium.org, M-A Ruel, Nico
Visibility:
Public.

Description

Add aura compile testing by default to likely areas (1). TBR=God NOTRY=true BUG=chromium:107599 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114490

Patch Set 1 #

Total comments: 5

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -1 line) Patch
M PRESUBMIT.py View 1 2 2 chunks +8 lines, -1 line 1 comment Download
A ui/aura/PRESUBMIT.py View 1 1 chunk +12 lines, -0 lines 0 comments Download
A ui/aura_shell/PRESUBMIT.py View 1 1 chunk +12 lines, -0 lines 0 comments Download
A ui/resources/aura/PRESUBMIT.py View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
Peter Mayo
9 years ago (2011-12-06 15:14:07 UTC) #1
Emmanuel Saint-loubert-Bié
The folders selected look good to me! However I do not know python so someone ...
9 years ago (2011-12-06 17:01:28 UTC) #2
oshima
http://codereview.chromium.org/8818013/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): http://codereview.chromium.org/8818013/diff/1/PRESUBMIT.py#newcode343 PRESUBMIT.py:343: if any(re.search(aura_re,f.LocalPath()) for f in change.AffectedFiles()): space after "," ...
9 years ago (2011-12-06 18:15:18 UTC) #3
Peter Mayo
blocked on http://codereview.chromium.org/8847005/ This avoids duplicating the builder definition to define the 'other' way of ...
9 years ago (2011-12-09 21:45:28 UTC) #4
M-A Ruel
+thakis since one of you will have to merge. lgtm http://codereview.chromium.org/8818013/diff/2001/PRESUBMIT.py File PRESUBMIT.py (right): http://codereview.chromium.org/8818013/diff/2001/PRESUBMIT.py#newcode341 ...
9 years ago (2011-12-09 21:51:40 UTC) #5
oshima
http://codereview.chromium.org/8818013/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): http://codereview.chromium.org/8818013/diff/1/PRESUBMIT.py#newcode344 PRESUBMIT.py:344: preferred.append('linux_aura_compile') On 2011/12/09 21:45:29, Peter Mayo wrote: > On ...
9 years ago (2011-12-09 21:52:54 UTC) #6
Nico
Is linux_aura on goma yet?
9 years ago (2011-12-09 21:58:11 UTC) #7
Peter Mayo (wrong one)
I cloned the state of linux at the time, On Fri, Dec 9, 2011 at ...
9 years ago (2011-12-09 21:59:47 UTC) #8
Nico
On Fri, Dec 9, 2011 at 1:59 PM, Peter Mayo <petermayo@google.com> wrote: > I cloned ...
9 years ago (2011-12-09 22:01:46 UTC) #9
Peter Mayo
On 2011/12/09 22:01:46, Nico wrote: > On Fri, Dec 9, 2011 at 1:59 PM, Peter ...
9 years ago (2011-12-14 06:01:12 UTC) #10
Peter Mayo
I am going to split this CL up so that we can trickle in these ...
9 years ago (2011-12-14 06:02:19 UTC) #11
Peter Mayo
Step 1
9 years ago (2011-12-14 20:41:02 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petermayo@chromium.org/8818013/9001
9 years ago (2011-12-14 20:41:22 UTC) #13
commit-bot: I haz the power
Presubmit check for 8818013-9001 failed and returned exit status 1. Running presubmit commit checks ...
9 years ago (2011-12-14 20:41:27 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petermayo@chromium.org/8818013/9001
9 years ago (2011-12-14 20:49:34 UTC) #15
commit-bot: I haz the power
Change committed as 114490
9 years ago (2011-12-14 20:49:50 UTC) #16
M-A Ruel
8 years, 10 months ago (2012-02-06 20:23:05 UTC) #17
http://codereview.chromium.org/8818013/diff/9001/PRESUBMIT.py
File PRESUBMIT.py (right):

http://codereview.chromium.org/8818013/diff/9001/PRESUBMIT.py#newcode12
PRESUBMIT.py:12: import re
FTR, I would have preferred this import to be function local.

Powered by Google App Engine
This is Rietveld 408576698