Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: PRESUBMIT.py

Issue 8818013: Add aura compile testing by default to likely areas. (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/aura/PRESUBMIT.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
===================================================================
--- PRESUBMIT.py (revision 114469)
+++ PRESUBMIT.py (working copy)
@@ -9,6 +9,9 @@
"""
+import re
M-A Ruel 2012/02/06 20:23:05 FTR, I would have preferred this import to be func
+
+
_EXCLUDED_PATHS = (
r"^breakpad[\\\/].*",
r"^net/tools/spdyshark/[\\\/].*",
@@ -335,4 +338,8 @@
f.LocalPath().endswith(('.mm', '.m')) for f in change.AffectedFiles())
if only_objc_files:
return ['mac_rel']
- return ['win_rel', 'linux_rel', 'mac_rel']
+ preferred = ['win_rel', 'linux_rel', 'mac_rel']
+ aura_re = '_aura[^/]*[.][^/]*'
+ if any(re.search(aura_re, f.LocalPath()) for f in change.AffectedFiles()):
+ preferred.append('linux_aura:compile')
+ return preferred
« no previous file with comments | « no previous file | ui/aura/PRESUBMIT.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698