Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 # Copyright (c) 2011 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2011 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 """Top-level presubmit script for Chromium. | 5 """Top-level presubmit script for Chromium. |
| 6 | 6 |
| 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts |
| 8 for more details about the presubmit API built into gcl. | 8 for more details about the presubmit API built into gcl. |
| 9 """ | 9 """ |
| 10 | 10 |
| 11 | 11 |
| 12 import re | |
| 13 | |
| 14 | |
| 12 _EXCLUDED_PATHS = ( | 15 _EXCLUDED_PATHS = ( |
| 13 r"^breakpad[\\\/].*", | 16 r"^breakpad[\\\/].*", |
| 14 r"^net/tools/spdyshark/[\\\/].*", | 17 r"^net/tools/spdyshark/[\\\/].*", |
| 15 r"^skia[\\\/].*", | 18 r"^skia[\\\/].*", |
| 16 r"^v8[\\\/].*", | 19 r"^v8[\\\/].*", |
| 17 r".*MakeFile$", | 20 r".*MakeFile$", |
| 18 ) | 21 ) |
| 19 | 22 |
| 20 | 23 |
| 21 _TEST_ONLY_WARNING = ( | 24 _TEST_ONLY_WARNING = ( |
| (...skipping 306 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 328 input_api, output_api)) | 331 input_api, output_api)) |
| 329 results.extend(_CheckSubversionConfig(input_api, output_api)) | 332 results.extend(_CheckSubversionConfig(input_api, output_api)) |
| 330 return results | 333 return results |
| 331 | 334 |
| 332 | 335 |
| 333 def GetPreferredTrySlaves(project, change): | 336 def GetPreferredTrySlaves(project, change): |
| 334 only_objc_files = all( | 337 only_objc_files = all( |
| 335 f.LocalPath().endswith(('.mm', '.m')) for f in change.AffectedFiles()) | 338 f.LocalPath().endswith(('.mm', '.m')) for f in change.AffectedFiles()) |
| 336 if only_objc_files: | 339 if only_objc_files: |
| 337 return ['mac'] | 340 return ['mac'] |
| 338 return ['win', 'linux', 'mac'] | 341 preferred = ['win', 'linux', 'mac'] |
|
M-A Ruel
2011/12/09 21:51:40
Note that it'll conflict with a CL from thakis whe
| |
| 342 aura_re = '_aura[^/]*[.][^/]*' | |
| 343 if any(re.search(aura_re, f.LocalPath()) for f in change.AffectedFiles()): | |
| 344 preferred.append('linux_aura:compile') | |
| 345 return preferred | |
| OLD | NEW |