Hook up the presubmit check for empty descriptions.

Hook up the presubmit check for empty descriptions.

BUG=none
TEST=none
NOTRY=true

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113063

[Lei Zhang, 2011-12-05 22:22:21]

Jochen saw a commit with an empty description.

[jochen (gone - plz use gerrit), 2011-12-05 22:24:38]

lgtm

[commit-bot: I haz the power, 2011-12-05 23:38:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/8812001/1

[commit-bot: I haz the power, 2011-12-05 23:39:45]

Change committed as 113063

[M-A Ruel, 2011-12-06 01:56:12]

http://codereview.chromium.org/8812001/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

http://codereview.chromium.org/8812001/diff/1/PRESUBMIT.py#newcode327
PRESUBMIT.py:327:
results.extend(input_api.canned_checks.CheckChangeHasDescription(
In fact, it's kind of pointless because the two checks above should fire anyway
on an empty description. So in any case, the dude bypassed presubmit checks.

[Lei Zhang, 2011-12-06 02:08:45]

http://codereview.chromium.org/8812001/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

http://codereview.chromium.org/8812001/diff/1/PRESUBMIT.py#newcode327
PRESUBMIT.py:327:
results.extend(input_api.canned_checks.CheckChangeHasDescription(
On 2011/12/06 01:56:12, Marc-Antoine Ruel wrote:
> In fact, it's kind of pointless because the two checks above should fire
anyway
> on an empty description. So in any case, the dude bypassed presubmit checks.

The two tests above only results in a warning on commit. This one results in an
error.