Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: PRESUBMIT.py

Issue 8812001: Hook up the presubmit check for empty descriptions. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
===================================================================
--- PRESUBMIT.py (revision 112749)
+++ PRESUBMIT.py (working copy)
@@ -324,6 +324,8 @@
input_api, output_api))
results.extend(input_api.canned_checks.CheckChangeHasTestField(
input_api, output_api))
+ results.extend(input_api.canned_checks.CheckChangeHasDescription(
M-A Ruel 2011/12/06 01:56:12 In fact, it's kind of pointless because the two ch
Lei Zhang 2011/12/06 02:08:45 The two tests above only results in a warning on c
+ input_api, output_api))
results.extend(_CheckSubversionConfig(input_api, output_api))
return results
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698