Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 # Copyright (c) 2011 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2011 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 """Top-level presubmit script for Chromium. | 5 """Top-level presubmit script for Chromium. |
| 6 | 6 |
| 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts |
| 8 for more details about the presubmit API built into gcl. | 8 for more details about the presubmit API built into gcl. |
| 9 """ | 9 """ |
| 10 | 10 |
| (...skipping 306 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 317 output_api, | 317 output_api, |
| 318 json_url='http://chromium-status.appspot.com/current?format=json')) | 318 json_url='http://chromium-status.appspot.com/current?format=json')) |
| 319 results.extend(input_api.canned_checks.CheckRietveldTryJobExecution(input_api, | 319 results.extend(input_api.canned_checks.CheckRietveldTryJobExecution(input_api, |
| 320 output_api, 'http://codereview.chromium.org', ('win', 'linux', 'mac'), | 320 output_api, 'http://codereview.chromium.org', ('win', 'linux', 'mac'), |
| 321 'tryserver@chromium.org')) | 321 'tryserver@chromium.org')) |
| 322 | 322 |
| 323 results.extend(input_api.canned_checks.CheckChangeHasBugField( | 323 results.extend(input_api.canned_checks.CheckChangeHasBugField( |
| 324 input_api, output_api)) | 324 input_api, output_api)) |
| 325 results.extend(input_api.canned_checks.CheckChangeHasTestField( | 325 results.extend(input_api.canned_checks.CheckChangeHasTestField( |
| 326 input_api, output_api)) | 326 input_api, output_api)) |
| 327 results.extend(input_api.canned_checks.CheckChangeHasDescription( | |
|
M-A Ruel
2011/12/06 01:56:12
In fact, it's kind of pointless because the two ch
Lei Zhang
2011/12/06 02:08:45
The two tests above only results in a warning on c
| |
| 328 input_api, output_api)) | |
| 327 results.extend(_CheckSubversionConfig(input_api, output_api)) | 329 results.extend(_CheckSubversionConfig(input_api, output_api)) |
| 328 return results | 330 return results |
| 329 | 331 |
| 330 | 332 |
| 331 def GetPreferredTrySlaves(project, change): | 333 def GetPreferredTrySlaves(project, change): |
| 332 only_objc_files = all( | 334 only_objc_files = all( |
| 333 f.LocalPath().endswith(('.mm', '.m')) for f in change.AffectedFiles()) | 335 f.LocalPath().endswith(('.mm', '.m')) for f in change.AffectedFiles()) |
| 334 if only_objc_files: | 336 if only_objc_files: |
| 335 return ['mac'] | 337 return ['mac'] |
| 336 return ['win', 'linux', 'mac'] | 338 return ['win', 'linux', 'mac'] |
| OLD | NEW |