Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8789018: Revert 113047 - Make ExtensionService use ExtensionSet. (Closed)

Created:
9 years ago by Yoyo Zhou
Modified:
9 years ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, jstritar+watch_chromium.org, ncarter (slow), darin-cc_chromium.org, akalin, Raghu Simha, kkania, brettw-cc_chromium.org, achuith+watch_chromium.org, mihaip+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, robertshield, Paweł Hajdan Jr., estade+watch_chromium.org, James Su, tim (not reviewing)
Visibility:
Public.

Description

Revert 113047 - Make ExtensionService use ExtensionSet. It broke ExtensionManagementApiBrowserTest.LaunchApp. Make ExtensionSet iterate like a set instead of a map. BUG=104091 TEST=existing tests Review URL: http://codereview.chromium.org/8733004 TBR=yoz@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113071

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+485 lines, -499 lines) Patch
MM chrome/browser/autocomplete/extension_app_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
MM chrome/browser/automation/automation_provider_observers.cc View 4 chunks +5 lines, -5 lines 0 comments Download
MM chrome/browser/automation/testing_automation_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
MM chrome/browser/background/background_application_list_model.cc View 2 chunks +3 lines, -3 lines 0 comments Download
MM chrome/browser/background/background_application_list_model_unittest.cc View 4 chunks +5 lines, -8 lines 0 comments Download
MM chrome/browser/background/background_contents_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
MM chrome/browser/debugger/devtools_window.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/browser_action_apitest.cc View 4 chunks +14 lines, -13 lines 0 comments Download
MM chrome/browser/extensions/component_loader_unittest.cc View 5 chunks +16 lines, -10 lines 0 comments Download
MM chrome/browser/extensions/extension_apitest.cc View 1 chunk +7 lines, -8 lines 0 comments Download
M chrome/browser/extensions/extension_browsertest.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/extensions/extension_browsertests_misc.cc View 22 chunks +66 lines, -92 lines 0 comments Download
MM chrome/browser/extensions/extension_context_menu_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
MM chrome/browser/extensions/extension_crash_recovery_browsertest.cc View 23 chunks +63 lines, -54 lines 0 comments Download
MM chrome/browser/extensions/extension_file_browser_private_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
MM chrome/browser/extensions/extension_info_map.cc View 1 chunk +4 lines, -4 lines 0 comments Download
MM chrome/browser/extensions/extension_management_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
MM chrome/browser/extensions/extension_management_browsertest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
MM chrome/browser/extensions/extension_override_apitest.cc View 3 chunks +8 lines, -8 lines 0 comments Download
MM chrome/browser/extensions/extension_preference_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_process_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
MM chrome/browser/extensions/extension_service.h View 5 chunks +11 lines, -9 lines 0 comments Download
MM chrome/browser/extensions/extension_service.cc View 21 chunks +103 lines, -68 lines 0 comments Download
MM chrome/browser/extensions/extension_service_unittest.cc View 5 chunks +8 lines, -8 lines 0 comments Download
MM chrome/browser/extensions/extension_startup_browsertest.cc View 2 chunks +11 lines, -20 lines 0 comments Download
MM chrome/browser/extensions/extension_tab_helper.cc View 2 chunks +5 lines, -4 lines 0 comments Download
MM chrome/browser/extensions/extension_toolbar_model.cc View 1 chunk +2 lines, -3 lines 0 comments Download
MM chrome/browser/extensions/extension_tts_engine_api.cc View 2 chunks +4 lines, -4 lines 0 comments Download
MM chrome/browser/extensions/extension_updater.cc View 1 chunk +2 lines, -2 lines 0 comments Download
MM chrome/browser/extensions/extension_updater_unittest.cc View 2 chunks +10 lines, -7 lines 0 comments Download
MM chrome/browser/extensions/extension_webrequest_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
MM chrome/browser/extensions/installed_loader.cc View 2 chunks +3 lines, -3 lines 0 comments Download
MM chrome/browser/extensions/network_delay_listener_unittest.cc View 3 chunks +6 lines, -7 lines 0 comments Download
MM chrome/browser/extensions/test_extension_service.h View 1 chunk +1 line, -1 line 0 comments Download
MM chrome/browser/extensions/test_extension_service.cc View 1 chunk +1 line, -1 line 0 comments Download
MM chrome/browser/extensions/unpacked_installer.cc View 1 chunk +5 lines, -2 lines 0 comments Download
MM chrome/browser/extensions/user_script_listener.cc View 1 chunk +1 line, -1 line 0 comments Download
MM chrome/browser/extensions/user_script_listener_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
MM chrome/browser/intents/web_intents_registry.cc View 1 chunk +2 lines, -2 lines 0 comments Download
MM chrome/browser/intents/web_intents_registry_unittest.cc View 6 chunks +32 lines, -28 lines 0 comments Download
MM chrome/browser/sync/test/integration/sync_extension_helper.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/themes/theme_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
MM chrome/browser/ui/browser_browsertest.cc View 1 chunk +4 lines, -5 lines 0 comments Download
MM chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.cc View 1 chunk +3 lines, -4 lines 0 comments Download
MM chrome/browser/ui/views/browser_actions_container_browsertest.cc View 1 chunk +8 lines, -5 lines 0 comments Download
MM chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 chunk +3 lines, -4 lines 0 comments Download
MM chrome/browser/ui/webui/ntp/app_launcher_handler.cc View 2 chunks +6 lines, -7 lines 0 comments Download
MM chrome/browser/ui/webui/options/extension_settings_handler.cc View 3 chunks +4 lines, -4 lines 0 comments Download
MM chrome/browser/ui/webui/options/search_engine_manager_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
MM chrome/common/extensions/extension_set.h View 3 chunks +6 lines, -31 lines 0 comments Download
MM chrome/common/extensions/extension_set.cc View 2 chunks +1 line, -9 lines 0 comments Download
MM chrome/renderer/extensions/extension_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Yoyo Zhou
9 years ago (2011-12-06 00:18:47 UTC) #1 

          

          

        


      

    

    

  











      		
    

  





  
    
  






  Powered by Google App Engine





  
This is Rietveld 408576698