Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1509)

Unified Diff: chrome/browser/extensions/network_delay_listener_unittest.cc

Issue 8789018: Revert 113047 - Make ExtensionService use ExtensionSet. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/installed_loader.cc ('k') | chrome/browser/extensions/test_extension_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/network_delay_listener_unittest.cc
===================================================================
--- chrome/browser/extensions/network_delay_listener_unittest.cc (revision 113069)
+++ chrome/browser/extensions/network_delay_listener_unittest.cc (working copy)
@@ -127,9 +127,9 @@
void LoadTestExtension1() {
LoadTestExtension(kTestExtensionId1);
- ASSERT_FALSE(service_->extensions()->is_empty());
- extension1_ = service_->extensions()->GetByID(kTestExtensionId1);
- ASSERT_TRUE(extension1_);
+ ASSERT_FALSE(service_->extensions()->empty());
+ extension1_ = service_->extensions()->at(0).get();
+ ASSERT_FALSE(extension1_ == NULL);
}
void SendExtensionLoadedNotification(const Extension* extension) {
@@ -197,9 +197,8 @@
LoadTestExtension1();
LoadTestExtension(kTestExtensionId2);
ASSERT_EQ(2u, service_->extensions()->size());
- const Extension* extension2 =
- service_->extensions()->GetByID(kTestExtensionId2);
- ASSERT_TRUE(extension2);
+ const Extension* extension2 = service_->extensions()->at(1).get();
+ ASSERT_FALSE(extension2 == NULL);
TestDelegate delegate;
scoped_ptr<TestURLRequest> request(StartTestRequest(&delegate, kTestUrl));
@@ -232,7 +231,7 @@
// Tests that there's no delay if no loaded extension needs one.
TEST_F(NetworkDelayListenerTest, NoDelayNoWebRequest) {
LoadTestExtension(kTestExtensionNoNetworkDelay);
- ASSERT_FALSE(service_->extensions()->is_empty());
+ ASSERT_FALSE(service_->extensions()->empty());
TestDelegate delegate;
scoped_ptr<TestURLRequest> request(StartTestRequest(&delegate, kTestUrl));
Property changes on: chrome/browser/extensions/network_delay_listener_unittest.cc
___________________________________________________________________
Added: svn:mergeinfo
« no previous file with comments | « chrome/browser/extensions/installed_loader.cc ('k') | chrome/browser/extensions/test_extension_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698