Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1906)

Unified Diff: chrome/browser/extensions/component_loader_unittest.cc

Issue 8789018: Revert 113047 - Make ExtensionService use ExtensionSet. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/browser_action_apitest.cc ('k') | chrome/browser/extensions/extension_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/component_loader_unittest.cc
===================================================================
--- chrome/browser/extensions/component_loader_unittest.cc (revision 113069)
+++ chrome/browser/extensions/component_loader_unittest.cc (working copy)
@@ -11,7 +11,6 @@
#include "chrome/browser/extensions/test_extension_service.h"
#include "chrome/common/chrome_paths.h"
#include "chrome/common/extensions/extension.h"
-#include "chrome/common/extensions/extension_set.h"
#include "chrome/common/pref_names.h"
#include "chrome/test/base/testing_pref_service.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -21,7 +20,7 @@
class MockExtensionService : public TestExtensionService {
private:
bool ready_;
- ExtensionSet extension_set_;
+ ExtensionList extension_list_;
public:
MockExtensionService() : ready_(false) {
@@ -29,30 +28,37 @@
virtual void AddExtension(const Extension* extension) OVERRIDE {
// ExtensionService must become the owner of the extension object.
- extension_set_.Insert(extension);
+ extension_list_.push_back(extension);
}
virtual void UnloadExtension(
const std::string& extension_id,
extension_misc::UnloadedExtensionReason reason) OVERRIDE {
// Remove the extension with the matching id.
- extension_set_.Remove(extension_id);
+ for (ExtensionList::iterator it = extension_list_.begin();
+ it != extension_list_.end();
+ ++it) {
+ if ((*it)->id() == extension_id) {
+ extension_list_.erase(it);
+ return;
+ }
+ }
}
virtual bool is_ready() OVERRIDE {
return ready_;
}
- virtual const ExtensionSet* extensions() const OVERRIDE {
- return &extension_set_;
+ virtual const ExtensionList* extensions() const OVERRIDE {
+ return &extension_list_;
}
void set_ready(bool ready) {
ready_ = ready;
}
- void clear_extensions() {
- extension_set_.Clear();
+ void clear_extension_list() {
+ extension_list_.clear();
}
};
@@ -211,7 +217,7 @@
unsigned int default_count = extension_service_.extensions()->size();
// Clear the list of loaded extensions, and reload with one more.
- extension_service_.clear_extensions();
+ extension_service_.clear_extension_list();
component_loader_.Add(manifest_contents_, extension_path_);
component_loader_.LoadAll();
@@ -231,7 +237,7 @@
// Now that the pref is set, check if it's added by default.
extension_service_.set_ready(false);
- extension_service_.clear_extensions();
+ extension_service_.clear_extension_list();
component_loader_.ClearAllRegistered();
component_loader_.AddDefaultComponentExtensions();
component_loader_.LoadAll();
Property changes on: chrome/browser/extensions/component_loader_unittest.cc
___________________________________________________________________
Added: svn:mergeinfo
« no previous file with comments | « chrome/browser/extensions/browser_action_apitest.cc ('k') | chrome/browser/extensions/extension_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698