Issue 8785005: aura: Make shadows be children of window layers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8785005: aura: Make shadows be children of window layers. (Closed)

Created:
9 years ago by Daniel Erat

Modified:
9 years ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, dhollowa+watch_chromium.org, Paweł Hajdan Jr., sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

aura: Make shadows be children of window layers. They used to be children of the root. This change makes shadows track their windows' transforms and simplifies the code (as we no longer need to track stacking or parenting changes). I am still slightly worried that shadows will look strange if we scale windows up or down, but we can figure out how to deal with that when we need to. BUG=101977 TEST=added; also hacked up StackingController to rotate and scale windows and checked that shadows were drawn as expected Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112823

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -120 lines)			Patch
M	ui/aura_shell/shadow_controller.h	View	2 chunks	+1 line, -9 lines	0 comments	Download
M	ui/aura_shell/shadow_controller.cc	View	4 chunks	+7 lines, -54 lines	0 comments	Download
M	ui/aura_shell/shadow_controller_unittest.cc	View	2 chunks	+16 lines, -57 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages