Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: ui/aura_shell/shadow_controller.h

Issue 8785005: aura: Make shadows be children of window layers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/aura_shell/shadow_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/aura_shell/shadow_controller.h
diff --git a/ui/aura_shell/shadow_controller.h b/ui/aura_shell/shadow_controller.h
index 6f6a602ab941ab3bea5ecc5ff5a00ca33a32cba2..2b2077b91b1e141ef5ec84fc800ffe775888a345 100644
--- a/ui/aura_shell/shadow_controller.h
+++ b/ui/aura_shell/shadow_controller.h
@@ -54,15 +54,10 @@ public:
virtual void OnWindowInitialized(aura::Window* window) OVERRIDE;
// aura::WindowObserver overrides:
- virtual void OnWindowParentChanged(
- aura::Window* window, aura::Window* parent) OVERRIDE;
virtual void OnWindowPropertyChanged(
aura::Window* window, const char* name, void* old) OVERRIDE;
- virtual void OnWindowVisibilityChanged(
- aura::Window* window, bool visible) OVERRIDE;
virtual void OnWindowBoundsChanged(
aura::Window* window, const gfx::Rect& bounds) OVERRIDE;
- virtual void OnWindowStackingChanged(aura::Window* window) OVERRIDE;
virtual void OnWindowDestroyed(aura::Window* window) OVERRIDE;
private:
@@ -80,12 +75,9 @@ public:
void HandlePossibleShadowVisibilityChange(aura::Window* window);
// Creates a new shadow for |window| and stores it in |window_shadows_|. The
- // shadow's visibility, bounds, and stacking are initialized appropriately.
+ // shadow's bounds are initialized and it is added to the window's layer.
void CreateShadowForWindow(aura::Window* window);
- // Stacks |shadow|'s layer directly beneath |window|'s layer.
- void StackShadowBelowWindow(Shadow* shadow, aura::Window* window);
-
WindowShadowMap window_shadows_;
DISALLOW_COPY_AND_ASSIGN(ShadowController);
« no previous file with comments | « no previous file | ui/aura_shell/shadow_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698