Resend requests when we only learn a connection has closed while

Resend requests when we learn a connection has closed while
trying to write to a socket.

Our old behavior caused network failures on servers that hang
up right after sending a file, but don't use
"connection: close".

BUG=105824
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113496

[willchan no longer on Chromium, 2011-12-07 18:46:27]

LGTM!

http://codereview.chromium.org/8775044/diff/5002/net/http/http_network_transa...
File net/http/http_network_transaction.cc (right):

http://codereview.chromium.org/8775044/diff/5002/net/http/http_network_transa...
net/http/http_network_transaction.cc:1190: // Under certain circumstances, we
may first learn a socket's been
Can you describe the circumstance? Explain that there's possibly a race between
the socket pool checking for socket connectedness and the actual read/write.

http://codereview.chromium.org/8775044/diff/5002/net/http/http_network_transa...
net/http/http_network_transaction.cc:1191: // disconnected when trying to
read/write from it or get its IP address,
getting the peer's IP address

[mmenke, 2011-12-07 19:34:10]

Thanks for the review

http://codereview.chromium.org/8775044/diff/5002/net/http/http_network_transa...
File net/http/http_network_transaction.cc (right):

http://codereview.chromium.org/8775044/diff/5002/net/http/http_network_transa...
net/http/http_network_transaction.cc:1190: // Under certain circumstances, we
may first learn a socket's been
On 2011/12/07 18:46:28, willchan wrote:
> Can you describe the circumstance? Explain that there's possibly a race
between
> the socket pool checking for socket connectedness and the actual read/write.

Done.  Added a link to the bug, too, as it now contains some actual details.

http://codereview.chromium.org/8775044/diff/5002/net/http/http_network_transa...
net/http/http_network_transaction.cc:1191: // disconnected when trying to
read/write from it or get its IP address,
On 2011/12/07 18:46:28, willchan wrote:
> getting the peer's IP address

Completely rewrote the sentence.

[commit-bot: I haz the power, 2011-12-07 21:18:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mmenke@chromium.org/8775044/8002

[commit-bot: I haz the power, 2011-12-07 23:04:53]

Change committed as 113496