Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Unified Diff: net/http/http_network_transaction.cc

Issue 8775044: Resend requests when we only learn a connection has closed while (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Response to comments Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/http/http_network_transaction_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_network_transaction.cc
===================================================================
--- net/http/http_network_transaction.cc (revision 112998)
+++ net/http/http_network_transaction.cc (working copy)
@@ -1187,6 +1187,14 @@
case ERR_CONNECTION_RESET:
case ERR_CONNECTION_CLOSED:
case ERR_CONNECTION_ABORTED:
+ // There can be a race between the socket pool checking checking whether a
+ // socket is still connected, receiving the FIN, and sending/reading data
+ // on a reused socket. If we receive the FIN between the connectedness
+ // check and writing/reading from the socket, we may first learn the socket
+ // is disconnected when we get a ERR_SOCKET_NOT_CONNECTED. This will most
+ // likely happen when trying to retrieve its IP address.
+ // See http://crbug.com/105824 for more details.
+ case ERR_SOCKET_NOT_CONNECTED:
if (ShouldResendRequest(error)) {
net_log_.AddEvent(
NetLog::TYPE_HTTP_TRANSACTION_RESTART_AFTER_ERROR,
« no previous file with comments | « no previous file | net/http/http_network_transaction_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698